Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: internalChecksAsSuccess #20572

Merged
merged 44 commits into from
Mar 4, 2023
Merged

feat!: internalChecksAsSuccess #20572

merged 44 commits into from
Mar 4, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 22, 2023

Changes

Adds new config option internalChecksAsSuccess

Context

Closes #7800

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

RahulGautamSingh and others added 12 commits February 20, 2023 15:23
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
26acf2c
@rarkins
feat!: default to rangeStrategy=auto, prefer update-lockfile (#19942)
dfd52ac 
Changes `rangeStrategy` default value from `'replace'` to `'auto'`.

Changes `auto` behavior so that `update-lockfile` is preferred if the manager supports the `updateLockedDependency()` function.

Closes #19800

BREAKING CHANGE: Renovate will now default to updating locked dependency versions. To revert to previous behavior, configure rangeStrategy=replace.
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
8214646 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
@rarkins
feat(cache): default cacheHardTtlMinutes to 24 hours (#20079)
4bdd48c
@rarkins
feat(go)!: default GOPROXY (#20081)
895cc26 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
@rarkins
fix(regex): don’t escape forward slash in fileMatch (#19314)
8846efe
@rarkins
feat(cache): file cache cleanup (#20061)
62db658 
Checks file cache for expired items at the end of a run. Non-breaking change but it may result in some long cleanup jobs for any bots which have been left to populate their package cache for a long time.

Closes #13732
@viceice @HonkingGoose @rarkins
feat(config): default dockerImagePrefix to containerbase (#20150)
f320601 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins
chore: fix artifacts tests
6e8c6c6
@rarkins
fix(versioning)!: bump short ranges to version (#20494)
c24ed82
@rarkins
refactor!: use packageName and not depName for datasource lookups (#2…
b0f8f6f 
…0474)
@rarkins
feat!: internalChecksAsSuccess
fd06afa 
Closes #78—
@rarkins rarkins requested review from viceice and secustor February 22, 2023 13:02
@rarkins rarkins changed the title feat! internalChecksAsSuccess feat!: internalChecksAsSuccess Feb 22, 2023
@rarkins
Copy link
Collaborator Author

rarkins commented Feb 22, 2023 •
edited
Loading

  • Real repo testing
  • Move some of the existing test changes into a refactor PR first

@rarkins rarkins added the breaking Breaking change, requires major version bump label Feb 22, 2023
viceice
viceice reviewed Feb 22, 2023
View reviewed changes
@rarkins rarkins requested a review from viceice February 22, 2023 16:32
@rarkins rarkins mentioned this pull request Feb 22, 2023
Merged
6 tasks
RahulGautamSingh and others added 4 commits February 23, 2023 06:30
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
a42fe41
@rarkins
feat!: default to rangeStrategy=auto, prefer update-lockfile (#19942)
ffbf279 
Changes `rangeStrategy` default value from `'replace'` to `'auto'`.

Changes `auto` behavior so that `update-lockfile` is preferred if the manager supports the `updateLockedDependency()` function.

Closes #19800

BREAKING CHANGE: Renovate will now default to updating locked dependency versions. To revert to previous behavior, configure rangeStrategy=replace.
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
b784f61 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
@rarkins
feat(cache): default cacheHardTtlMinutes to 24 hours (#20079)
0c681f7
RahulGautamSingh and others added 13 commits February 27, 2023 06:31
@RahulGautamSingh @rarkins
feat(config)!: add new option constraintsFiltering (#19992)
3125af9
@rarkins
feat!: default to rangeStrategy=auto, prefer update-lockfile (#19942)
ab17816 
Changes `rangeStrategy` default value from `'replace'` to `'auto'`.

Changes `auto` behavior so that `update-lockfile` is preferred if the manager supports the `updateLockedDependency()` function.

Closes #19800

BREAKING CHANGE: Renovate will now default to updating locked dependency versions. To revert to previous behavior, configure rangeStrategy=replace.
@rarkins
feat(config)!: non-zero defaults for PR concurrent, hourly limits (#1…
46ca5a4 
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
@rarkins
feat(cache): default cacheHardTtlMinutes to 24 hours (#20079)
f4adef9
@rarkins
feat(go)!: default GOPROXY (#20081)
0282067 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
@rarkins
fix(regex): don’t escape forward slash in fileMatch (#19314)
333f5c2
@rarkins
feat(cache): file cache cleanup (#20061)
34e4fa7 
Checks file cache for expired items at the end of a run. Non-breaking change but it may result in some long cleanup jobs for any bots which have been left to populate their package cache for a long time.

Closes #13732
@viceice @HonkingGoose @rarkins
feat(config): default dockerImagePrefix to containerbase (#20150)
550afb1 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins
chore: fix artifacts tests
feeefe1
@rarkins
fix(versioning)!: bump short ranges to version (#20494)
0ac2bf6
@rarkins
refactor!: use packageName and not depName for datasource lookups (#2…
6474aa6 
…0474)
@devversion @RahulGautamSingh
@rarkins @viceice @HonkingGoose
feat!: update github-releases datasource digest computation to use …
612ab32 
…git tag, and preserve existing digest semantics as separate datasource (#20178)

Co-authored-by: RahulGautamSingh <rahultesnik@gmail.com>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@secustor @rarkins
feat!: default to semver-coerced instead of semver (#20573)
491f0eb
@rarkins rarkins marked this pull request as ready for review March 4, 2023 05:27
@rarkins rarkins requested a review from JamieMagee as a code owner March 4, 2023 05:27
@rarkins rarkins merged commit 789238c into v35 Mar 4, 2023
@rarkins rarkins deleted the feat/7800-internalChecksAsSuccess branch March 4, 2023 09:30
rarkins added a commit that referenced this pull request Mar 8, 2023
@rarkins
feat!: internalChecksAsSuccess (#20572)
3365726
rarkins added a commit that referenced this pull request Mar 10, 2023
@rarkins
feat!: internalChecksAsSuccess (#20572)
2ed320f
rarkins added a commit that referenced this pull request Mar 10, 2023
@rarkins
feat!: internalChecksAsSuccess (#20572)
2c54fc6
rarkins added a commit that referenced this pull request Mar 10, 2023
@rarkins
feat!: internalChecksAsSuccess (#20572)
92b869e 
Adds new config option `internalChecksAsSuccess`, defaulting to `false`.

Closes #7800

BREAKING CHANGE: Internal checks such as `renovate/stability-days` will no longer count as passing/green, meaning that actions such as `automerge` won't
occur if the only checks are Renovate internal ones. Set `internalChecksAsSuccess=true` to restore existing behavior.
rarkins added a commit that referenced this pull request Mar 10, 2023
@rarkins
feat!: internalChecksAsSuccess (#20572)
f765e6f 
Adds new config option `internalChecksAsSuccess`, defaulting to `false`.

Closes #7800

BREAKING CHANGE: Internal checks such as `renovate/stability-days` will no longer count as passing/green, meaning that actions such as `automerge` won't
occur if the only checks are Renovate internal ones. Set `internalChecksAsSuccess=true` to restore existing behavior.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@secustor secustor Awaiting requested review from secustor

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump v35
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rarkins @viceice @HonkingGoose @RahulGautamSingh @devversion @secustor