Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicitly configure public GOPROXY by default #20040

Closed
rarkins opened this issue Jan 26, 2023 · 2 comments
Closed

Implicitly configure public GOPROXY by default #20040

rarkins opened this issue Jan 26, 2023 · 2 comments
Assignees
@rarkins
Labels
breaking Breaking change, requires major version bump datasource:go priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jan 26, 2023

What would you like Renovate to be able to do?

Default to using GOPROXY

If you have any ideas on how this should be implemented, please tell us here.

Add it as a default, although it must be possible for self-hosted users to override or remove it

Is this a feature you are interested in implementing yourself?

Maybe
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others breaking Breaking change, requires major version bump datasource:go status:requirements Full requirements are not yet known, so implementation should not be started labels Jan 26, 2023
@rarkins rarkins mentioned this issue Jan 26, 2023
Closed
@rarkins
Copy link
Collaborator Author

rarkins commented Jan 26, 2023

I believe go itself defaults to https://proxy.golang.org,direct if the value is unset. We can perhaps simply do process.env.GOPROXY ??= 'https://proxy.golang.org,direct' at startup before the first call to any go datasource. Self-hosted users could disable it by setting GOPROXY=direct.

rarkins added a commit that referenced this issue Jan 28, 2023
@rarkins
feat(go)!: default GOPROXY value
4d50e81 
Closes #20040
@rarkins rarkins mentioned this issue Jan 28, 2023
Merged
6 tasks
@rarkins rarkins self-assigned this Jan 28, 2023
rarkins added a commit that referenced this issue Jan 29, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
865316a 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Jan 29, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
0994718 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Jan 30, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
4b8dca0 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Jan 31, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
352a9ae 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Feb 4, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
1fadf7b 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Feb 10, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
4ecd182 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Feb 17, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
0705159 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Feb 20, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
895cc26 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Feb 23, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
1b58035 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Feb 25, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
afa3062 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Feb 27, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
0282067 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Mar 4, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
abdee35 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Mar 8, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
8d845c5 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Mar 10, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
bb51f6c 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Mar 10, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
b1dbcc0 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
rarkins added a commit that referenced this issue Mar 10, 2023
@rarkins
feat(go)!: default GOPROXY (#20081)
b0a43cb 
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 35.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
breaking Breaking change, requires major version bump datasource:go priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rarkins @renovate-release