-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for native .node modules to remix-dev (making tailwind integration pain free) #703
Conversation
Hi @sync, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Also would love to know how you would want to test this ? I tried to run the test locally but few are already failing |
5cbbe5e
to
aabbb22
Compare
aabbb22
to
e5db18e
Compare
ab9dac4
to
172ecc9
Compare
I would get rid of all the doc changes you made as they seem largely unrelated and would make it harder to get your merged (might be considered rude to change coding conventions like that) |
so postcss can run on the server for example (see itsMapleLeaf/remix-tailwind#1)
e5db18e
to
6310919
Compare
If you haven't, try to |
yes all good did it already :-) |
Thanks for taking the time here and sorry for not looking at this sooner (also sorry about the dev branch force pushes--that shouldn't have ever happened). Since we deploy to non-node environments too, I'm not sure what the implications are here. I'm closing this in favor of you opening up a discussion so we can figure out if we can do this or not given our multi-environment nature. You mind opening the discussion over here? https://github.com/remix-run/remix/discussions/new?category=ideas |
Was checking out remix-tailwind and it had issues on OSX due to fsevents use of .node modules in OSX. I think remix-tailwind is a super nice way to do tailwind in remix, pain free and it would be nice if our OSX users could also use it.
Here you can find more details about the issue:
itsMapleLeaf/remix-tailwind#1
This code was originated from here and written by Evan:
evanw/esbuild#1051
For anyone interested trying this fix, feel free to:
@remix-run+dev+1.0.6.patch.zip