Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Fails on MacOS #1

Open
itsMapleLeaf opened this issue Nov 24, 2021 · 7 comments
Open

Fails on MacOS #1

itsMapleLeaf opened this issue Nov 24, 2021 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@itsMapleLeaf
Copy link
Owner

itsMapleLeaf commented Nov 24, 2021

CI run for reference: https://github.com/itsMapleLeaf/remix-tailwind/runs/4310332190?check_suite_focus=true#step:6:22

PostCSS has a dependency on fsevents, a mac-only native module, and Remix isn't configured to load .node files through esbuild, so we have a mac-only error.

@itsMapleLeaf itsMapleLeaf added bug Something isn't working help wanted Extra attention is needed labels Nov 24, 2021
@sync
Copy link

sync commented Nov 26, 2021

I tried patching remix.run dev module with this and it worked: evanw/esbuild#1051

@itsMapleLeaf
Copy link
Owner Author

It sounds like a PR needs to be made to remix, then?

@sync
Copy link

sync commented Nov 26, 2021

@sync
Copy link

sync commented Nov 26, 2021

yes by the look of it, but not sure if it will fly

@sync
Copy link

sync commented Nov 26, 2021

Want me to do it ? (not sure if I will have time to do it this week)

@itsMapleLeaf
Copy link
Owner Author

Want me to do it ? (not sure if I will have time to do it this week)

Yeah, since you already have the working and tested code, go for it 👍

@sync
Copy link

sync commented Nov 27, 2021

I've sent a PR to remix, need to figure out how to test it

sync added a commit to sync/remix that referenced this issue Dec 1, 2021
sync added a commit to sync/remix that referenced this issue Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants