Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): treat imported assets from node_modules as external #6813

Merged
merged 6 commits into from
Aug 8, 2023
Merged

fix(dev): treat imported assets from node_modules as external #6813

merged 6 commits into from
Aug 8, 2023

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Jul 12, 2023 •
edited by MichaelDeBoey
Loading

Closes #1909

  • Docs
  • Tests

Testing Strategy: added an integration test

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f9bd868

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori self-assigned this Aug 4, 2023
@MichaelDeBoey MichaelDeBoey linked an issue Aug 6, 2023 that may be closed by this pull request
Importing PNG/SVG from node_modules failing #1909
Closed
MichaelDeBoey
MichaelDeBoey requested changes Aug 6, 2023
View reviewed changes
integration/svg-in-node-modules-test.ts Outdated Show resolved Hide resolved
integration/svg-in-node-modules-test.ts Outdated Show resolved Hide resolved
lpsinger and others added 3 commits August 6, 2023 23:01
@lpsinger @MichaelDeBoey
Update integration/svg-in-node-modules-test.ts
e8567c0 
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@lpsinger @MichaelDeBoey
Update integration/svg-in-node-modules-test.ts
61dc58a 
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@pcattori
Merge branch 'dev' into fix-import-svg-from-node-modules
7b51abe
@pcattori pcattori merged commit 9953532 into remix-run:dev Aug 8, 2023
@pcattori pcattori mentioned this pull request Aug 8, 2023
Closed
@lpsinger lpsinger deleted the fix-import-svg-from-node-modules branch August 8, 2023 19:13
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-a179aa7-20230809 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

lpsinger added a commit to lpsinger/remix that referenced this pull request Aug 16, 2023
@lpsinger
Add changeset for remix-run#6813
4289a3f
brophdawg11 added a commit that referenced this pull request Aug 16, 2023
@lpsinger @brophdawg11
chore: add changeset for #6813 (#7182)
cb97bbf 
Co-authored-by: Matt Brophy <matt@brophy.org>
@github-actions github-actions bot mentioned this pull request Aug 28, 2023
Merged
@KarelVerschraegen KarelVerschraegen mentioned this pull request Sep 12, 2023
Closed
lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this pull request Sep 25, 2023
@lpsinger
Remove workaround for asset imports from node_modules
7fa2d20 
This workaround is no longer needed because
remix-run/remix#6813 has been fixed
upstream.
@lpsinger lpsinger mentioned this pull request Sep 25, 2023
Merged
lpsinger added a commit to nasa-gcn/gcn.nasa.gov that referenced this pull request Sep 25, 2023
@lpsinger
Remove workaround for asset imports from node_modules
43f0c98 
This workaround is no longer needed because
remix-run/remix#6813 has been fixed
upstream.
Vidushi-GitHub pushed a commit to Vidushi-GitHub/gcn.nasa.gov that referenced this pull request Oct 11, 2023
@lpsinger @Vidushi-GitHub
Remove workaround for asset imports from node_modules
ccec375 
This workaround is no longer needed because
remix-run/remix#6813 has been fixed
upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey requested changes

@pcattori pcattori pcattori approved these changes

Assignees

@pcattori pcattori

Labels
CLA Signed package:dev
Projects
No open projects
v2
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing PNG/SVG from node_modules failing
4 participants
@lpsinger @pcattori @MichaelDeBoey @brophdawg11