Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for asset imports from node_modules #1422

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

lpsinger
Copy link
Member

@lpsinger lpsinger commented Sep 25, 2023

This workaround is no longer needed because remix-run/remix#6813 has been fixed upstream.

This workaround is no longer needed because
remix-run/remix#6813 has been fixed
upstream.
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (73e115f) 5.66% compared to head (7fa2d20) 5.66%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1422   +/-   ##
=====================================
  Coverage   5.66%   5.66%           
=====================================
  Files        114     114           
  Lines       2596    2596           
  Branches     277     277           
=====================================
  Hits         147     147           
  Misses      2447    2447           
  Partials       2       2           
Files Changed Coverage Δ
app/components/Spinner.tsx 0.00% <0.00%> (ø)
app/root.tsx 0.00% <0.00%> (ø)
app/routes/circulars._index.tsx 0.00% <0.00%> (ø)
app/routes/user.endorsements/route.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpsinger lpsinger merged commit 43f0c98 into nasa-gcn:main Sep 25, 2023
@lpsinger lpsinger deleted the node_modules_asset_workaround branch September 25, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants