Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: add typechecking for deno (#4715)" #4856

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Dec 13, 2022

This partially reverts #4715.

running into issues with package publishing due to Deno trying to fetch the new version before it's published - will look into bringing it back after the fact

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

⚠️ No Changeset found

Latest commit: f96b9d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh merged commit d017db3 into dev Dec 16, 2022
@mcansh mcansh deleted the logan/revert-deno-typechecking branch December 16, 2022 21:13
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Dec 16, 2022
@MichaelDeBoey
Copy link
Member

@mcansh Reverting this broke linting

https://github.com/remix-run/remix/actions/runs/3716871751/jobs/6303686481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants