Revert "ci: add typechecking for deno (#4715)" (#4856)

remix-run · Dec 16, 2022 · 7086b49 · 7086b49
1 parent 07b9b0a
commit 7086b49
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 53 deletions.
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -39,11 +39,6 @@ jobs:
           node-version-file: ".nvmrc"
           cache: "yarn"
 
-      - name: 🦕 Setup deno
-        uses: denoland/setup-deno@v1
-        with:
-          deno-version: vx.x.x
-
       - name: 📥 Install deps
         run: yarn --frozen-lockfile
 

diff --git a/.github/workflows/reusable-test.yml b/.github/workflows/reusable-test.yml
@@ -31,11 +31,6 @@ jobs:
           node-version-file: ".nvmrc"
           cache: "yarn"
 
-      - name: 🦕 Setup deno
-        uses: denoland/setup-deno@v1
-        with:
-          deno-version: vx.x.x
-
       - name: 📥 Install deps
         run: yarn --frozen-lockfile
 
@@ -66,11 +61,6 @@ jobs:
           node-version: ${{ matrix.node }}
           cache: "yarn"
 
-      - name: 🦕 Setup deno
-        uses: denoland/setup-deno@v1
-        with:
-          deno-version: vx.x.x
-
       - name: 📥 Install deps
         run: yarn --frozen-lockfile
 
@@ -103,11 +93,6 @@ jobs:
           node-version: ${{ matrix.node }}
           cache: "yarn"
 
-      - name: 🦕 Setup deno
-        uses: denoland/setup-deno@v1
-        with:
-          deno-version: vx.x.x
-
       - name: 📥 Install deps
         run: yarn --frozen-lockfile
 
@@ -139,11 +124,6 @@ jobs:
           node-version: ${{ matrix.node }}
           cache: "yarn"
 
-      - name: 🦕 Setup deno
-        uses: denoland/setup-deno@v1
-        with:
-          deno-version: vx.x.x
-
       - name: 📥 Install deps
         run: yarn --frozen-lockfile
 
@@ -175,11 +155,6 @@ jobs:
           node-version: ${{ matrix.node }}
           cache: "yarn"
 
-      - name: 🦕 Setup deno
-        uses: denoland/setup-deno@v1
-        with:
-          deno-version: vx.x.x
-
       - name: 📥 Install deps
         run: yarn --frozen-lockfile
 

diff --git a/packages/remix-deno/server.ts b/packages/remix-deno/server.ts
@@ -12,7 +12,7 @@ function defaultCacheControl(url: URL, assetsPublicPath = "/build/") {
 }
 
 export function createRequestHandler<
-  Context extends AppLoadContext | undefined = undefined,
+  Context extends AppLoadContext | undefined = undefined
 >({
   build,
   mode,
@@ -22,11 +22,11 @@ export function createRequestHandler<
   mode?: string;
   getLoadContext?: (request: Request) => Promise<Context> | Context;
 }) {
-  const handleRequest = createRemixRequestHandler(build, mode);
+  let handleRequest = createRemixRequestHandler(build, mode);
 
   return async (request: Request) => {
     try {
-      const loadContext = await getLoadContext?.(request);
+      let loadContext = await getLoadContext?.(request);
 
       return handleRequest(request, loadContext);
     } catch (error: unknown) {
@@ -53,12 +53,12 @@ export async function serveStaticFiles(
     cacheControl?: string | ((url: URL) => string);
     publicDir?: string;
     assetsPublicPath?: string;
-  },
+  }
 ) {
-  const url = new URL(request.url);
+  let url = new URL(request.url);
 
-  const headers = new Headers();
-  const contentType = mime.getType(url.pathname);
+  let headers = new Headers();
+  let contentType = mime.getType(url.pathname);
   if (contentType) {
     headers.set("Content-Type", contentType);
   }
@@ -71,9 +71,9 @@ export async function serveStaticFiles(
     headers.set("Cache-Control", defaultCacheControl(url, assetsPublicPath));
   }
 
-  const filePath = path.join(publicDir, url.pathname);
+  let filePath = path.join(publicDir, url.pathname);
   try {
-    const file = await Deno.readFile(filePath);
+    let file = await Deno.readFile(filePath);
     return new Response(file, { headers });
   } catch (error) {
     if (error.code === "EISDIR" || error.code === "ENOENT") {
@@ -84,7 +84,7 @@ export async function serveStaticFiles(
 }
 
 export function createRequestHandlerWithStaticFiles<
-  Context extends AppLoadContext | undefined = undefined,
+  Context extends AppLoadContext | undefined = undefined
 >({
   build,
   mode,
@@ -103,7 +103,7 @@ export function createRequestHandlerWithStaticFiles<
     assetsPublicPath?: string;
   };
 }) {
-  const remixHandler = createRequestHandler({ build, mode, getLoadContext });
+  let remixHandler = createRequestHandler({ build, mode, getLoadContext });
 
   return async (request: Request) => {
     try {

diff --git a/scripts/build.mjs b/scripts/build.mjs
@@ -1,23 +1,11 @@
 import { spawn } from "cross-spawn";
-import glob from "glob";
 
 const args = process.argv.slice(2);
 const publish = process.env.CI || args.includes("--publish");
 const tsc = process.env.CI || args.includes("--tsc") || publish;
-// const denoCheck = process.env.CI || args.includes("--deno");
-const denoCheck = false;
 
 exec("yarn", ["rollup", "-c"])
   .then(() => tsc && exec("yarn", ["tsc", "-b"]))
-  .then(
-    () =>
-      denoCheck &&
-      exec("deno", [
-        "check",
-        "--import-map=.vscode/deno_resolve_npm_imports.json",
-        ...glob.sync("packages/remix-deno/**/*.ts"),
-      ])
-  )
   .then(() => publish && exec("node", ["scripts/copy-build-to-dist.mjs"]))
   .then(() => process.exit(0))
   .catch((err) => {