-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to Jest v29 #9895
Conversation
|
1a32aba
to
2faf710
Compare
OK, got rid of the extraneous commits, so this should be good to go 👍 |
@@ -9,6 +10,13 @@ module.exports = { | |||
setupFiles: ["./__tests__/setup.ts"], | |||
moduleNameMapper: { | |||
"^@remix-run/router$": "<rootDir>/../router/index.ts", | |||
"^@remix-run/web-blob$": require.resolve("@remix-run/web-blob"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally you would provide CJS entry points for node
browser
and then we'd be able to avoid this. Right now there are both CJS and ESM entry points for node
, but browser
only has ESM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimenB I guess remix-run/web-std-io#43 is what you're referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep 🙂
Thanks for doing this @timdorr 🙌. I've been meaning to get to this now that 1.10 went out. I'll try to get this merged once we get the current |
Cool. If there are conflicts, I can take care of them. I've still got my sed scripts in my terminal history. |
Rebased on the latest |
🎉 |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Recreating @SimenB's #9253 because I'm not able to push with a merge from a different branch for some reason...
Anyways, this updates us to a newer Jest 29 setup and resolves any update conflicts or issues therein. You can read what Simen did in the original PR and this is just a continuation of that.