-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to Jest v29 #9253
Conversation
|
Hi @SimenB, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
* docs(components/await): fix typo * chore: sign CLA
* ci(release): sync with remix * ci: sync with remix * Delete postrelease.yml * ci: sync latest changes around getting previous release
Hey team, any update on getting this merged? Jest 28+ doesn't appear to be compatible with Remix packages without addressing the package import issue mentioned above. Thanks! |
I fixed the conflicts, but it looks like there's been enough updates since this PR to require more changes. Let me look into it... |
@timdorr seems like snapshots are different since Jest 29 https://jestjs.io/blog/2022/08/25/jest-29 and need to be updated. |
OK, now for the fun part: This was based on |
Switching to #9895 because I can't push to this remote branch anymore. Not Simen's fault, just a GitHub thing. |
👋
I noticed you were on an old version when looking through the code, so I thought to update it.
Main changes are:
jsdom
(changed default in Jest 27)@remix-run/*
modules to their CJS counterpartexports
, and those modules always serving ESM when Jest providesbrowser
andrequire
conditions. See https://jestjs.io/docs/28.x/upgrading-to-jest28#packagejson-exportsexports
in those modules, but I didn't look into it