refactor(x/ecocredit): migrate ecocredit server to submodules

[technicallyty]

Description

Closes: #728

• begins removal of some legacy code (mainly deleting msg_server, query_server)
• removes registration of old v1alpha types
• cleanups submodule Keeper instantiation
• removes redundant integration tests (everything in testsuite/tx.go and testsuite/query.go was already covered by keeper tests).
• cleans up scenario tests in testsuite/suite.go.
• comments out genesis tests (will be updated by update ecocredit genesis to use v1 types #976)
• changes module registration to use v1 params

there is more to remove/cleanup, but figured i'd stop here to keep the diff manageable. Main concern is with integration tests. Might be helpful to discuss a better approach to these tests in an extended call?

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[technicallyty]

looks like theres still a CI failures, but its related to x/group requiring ecocredit.MsgServer 🙄, not sure if worth fixing?

[ryanchristo]

Looking good. Given the amount of code commented out in relation to the genesis updates, I think we should focus on getting #977 reviewed and merged first.

[ryanchristo]

I think we're good to go on updating and including these changes now when you get a chance.

[codecov]

Codecov Report

Merging #995 (9d648bf) into master (002a876) will increase coverage by 9.43%.
The diff coverage is 98.88%.

@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
+ Coverage   59.61%   69.05%   +9.43%     
==========================================
  Files         230      223       -7     
  Lines       23289    21283    -2006     
==========================================
+ Hits        13884    14697     +813     
+ Misses       8063     5272    -2791     
+ Partials     1342     1314      -28     

Flag	Coverage Δ
experimental-codecov	68.95% <98.88%> (+9.43%)	⬆️
stable-codecov	62.97% <98.88%> (+9.70%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[ryanchristo]

@technicallyty is this ready for another review? Can you fix the simulation tests?

[ryanchristo]

Looking good. Just a couple comments.

[ryanchristo]

Looks good to me. Maybe we should update the title of the pull request to something like:

refactor(x/ecocredit): migrate ecocredit server to submodules

The pull request does more than "update integration tests". Also "clean up legacy code" is implied by the migration.

[ryanchristo]

I think we can use basket, core, and marketplace rather than adding types to each but ok to leave as is.

[aleem1314]

lgtm