Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit server implementation unit and integration tests #1042

Closed
3 of 7 tasks
Tracked by #818
ryanchristo opened this issue Apr 20, 2022 · 1 comment
Closed
3 of 7 tasks
Tracked by #818

Audit server implementation unit and integration tests #1042

ryanchristo opened this issue Apr 20, 2022 · 1 comment
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Tests

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Apr 20, 2022

Summary

As a followup to #995 and #1038, we need to perform an audit of our server implementation tests. In #995, we refine our client tests to be more focused on testing endpoints and commands (i.e. not duplicating the test cases that should be covered elsewhere). With #1038, this issue should have been caught by our tests.

While implementing #1021, I noticed several tests using an assumed key rather than using the key returned that is provided by InsertReturningId. I may have repeated this pattern in some of my updates as well, which could be the cause of the issue that went unnoticed. Another potential cause could have been a lack of scenarios such as creating multiple classes, projects, or batches, which is a separate issue that came up with #1032.

Problem Definition

Our unit tests and integration tests should catch issues such as the two mentioned above.

Proposal

Audit our unit and integration tests for the ecocredit server implementation and apply fixes:

For each of these items, we should make sure we are not assuming the key and using InsertReturningId and we should make sure we are providing scenarios with multiple classes, projects, and batches.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo
Copy link
Member Author

Closing as msg server tests have been rewritten and reviewed as a part of #893, #894, and #895.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Tests
Projects
None yet
Development

No branches or pull requests

2 participants