refactor(x/ecocredit): consistent use of id, key, and abbreviation #1021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
- Coverage 49.20% 48.91% -0.29%
==========================================
Files 225 225
Lines 23408 23429 +21
==========================================
- Hits 11517 11461 -56
- Misses 10638 10720 +82
+ Partials 1253 1248 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
| // credit_type_abbrev is the abbreviation of the credit type. | ||
| string credit_type_abbrev = 5; |
There was a problem hiding this comment.
I think we should be using a credit_type_key here as well but opened a separate issue (#1030) because that would require additional refactoring and this pull request is already pretty large.
| // batch_denom is the unique identifier of the credit batch formed from the | ||
| // project id, the batch sequence number, and the start and end date of the | ||
| // credit batch. | ||
| string batch_denom = 4; |
There was a problem hiding this comment.
This could also simply be denom rather than batch_denom. Opened #1031.
|
Any ideas why this is producing a group module error in the experimental simulation tests? This pull request does not make any changes to the group module. Maybe @aleem1314 you have an idea? https://github.com/regen-network/regen-ledger/runs/6067693726?check_suite_focus=true |
| // batch_denom is the unique identifier of the credit batch formed from the | ||
| // project id, the batch sequence number, and the start and end date of the | ||
| // credit batch. | ||
| string batch_denom = 4; |
Description
Closes: #992
This pull request updates
idin state proto tokeyand applies consistent use of id, key, and abbreviation.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change