Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/data): remove oneof and update validation #946

Merged
merged 6 commits into from
Mar 29, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Mar 26, 2022

Description

Closes: #872

This pull request updates ContentHash to no longer use oneof, which breaks amino signing. This pull request also improves validation checks and updates MediaType to RawMediaType, which is specific to raw content hashes and aligns with the namespace used for graph content hashes.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #946 (77d7166) into master (70cba99) will increase coverage by 0.06%.
The diff coverage is 97.67%.

❗ Current head 77d7166 differs from pull request most recent head e478d12. Consider uploading reports for the commit e478d12 to get more accurate results

@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
+ Coverage   73.15%   73.21%   +0.06%     
==========================================
  Files         196      196              
  Lines       23155    23116      -39     
==========================================
- Hits        16938    16924      -14     
+ Misses       4934     4922      -12     
+ Partials     1283     1270      -13     
Flag Coverage Δ
experimental-codecov 73.04% <97.67%> (+0.04%) ⬆️
stable-codecov 68.04% <97.67%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are removing oneof? Can we use blake3 instead?
PS: I thought we want to update proto first (before updating code) ;)

@ryanchristo
Copy link
Member Author

Why we are removing oneof?

We are removing oneof because it breaks amino signing, i.e. "This pull request updates ContentHash to no longer use oneof, which breaks amino signing".

Can we use blake3 instead?

That's being discussed in #248 and would be a separate pull request.

PS: I thought we want to update proto first (before updating code) ;)

That's the process for new features that are in the design phase. I don't think it's necessary when fixing an existing feature but maybe that's something we can further discuss. Seems unnecessary for the change here or adding queries.

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ryanchristo ryanchristo enabled auto-merge (squash) March 29, 2022 14:31
@ryanchristo ryanchristo merged commit 7d43caa into master Mar 29, 2022
@ryanchristo ryanchristo deleted the ryan/872-data-content-hash branch March 29, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update data content hash to support amino signing
4 participants