Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data content hash to support amino signing #872

Closed
4 tasks
Tracked by #818
ryanchristo opened this issue Mar 10, 2022 · 0 comments · Fixed by #946
Closed
4 tasks
Tracked by #818

Update data content hash to support amino signing #872

ryanchristo opened this issue Mar 10, 2022 · 0 comments · Fixed by #946
Assignees
@ryanchristo
Labels
Scope: x/data Issues that update the x/data module Type: Refactor A code change that neither fixes a bug nor adds a feature
Milestone
v4.0 - Llangorse ...

Comments

@ryanchristo
Copy link
Member

Summary

Ref: #868 (comment)

When migrating data proto files to v1, it was pointed out that using oneof in ContentHash will break amino signing. We need to update ContentHash to support amino signing.

Problem Definition

Using oneof in ContentHash will break amino signing.

Proposal

Maybe we can split them into separate fields (like #790).

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added the Scope: x/data Issues that update the x/data module label Mar 10, 2022
@ryanchristo ryanchristo added this to the v4.0 - Llangorse Upgrade milestone Mar 10, 2022
This was referenced Mar 10, 2022
Merged
Closed
Closed
@ryanchristo ryanchristo self-assigned this Mar 25, 2022
@ryanchristo ryanchristo mentioned this issue Mar 26, 2022
Merged
19 tasks
@ryanchristo ryanchristo added the Type: Refactor A code change that neither fixes a bug nor adds a feature label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanchristo ryanchristo

Labels
Scope: x/data Issues that update the x/data module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
v4.0 - Llangorse Upgrade
Development

Successfully merging a pull request may close this issue.

refactor(x/data): remove oneof and update validation regen-network/regen-ledger
1 participant
@ryanchristo