-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate data proto to v1 #868
Conversation
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
+ Coverage 33.19% 33.27% +0.08%
==========================================
Files 185 185
Lines 57325 57480 +155
==========================================
+ Hits 19027 19127 +100
- Misses 36682 36723 +41
- Partials 1616 1630 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
// ContentHash specifies a hash based content identifier for a piece of data | ||
message ContentHash { | ||
// sum selects the type of content hash | ||
oneof sum { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break amino signing. Maybe we can split them into separate fields (like #790).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a followup task #872
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Description
Closes: #849
Update data proto to
v1
following #708 and retroactively updatev1alpha2
to match proto released inv2.0.0-beta1
.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change