Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate data proto to v1 #868

Merged
merged 11 commits into from
Mar 11, 2022
Merged

chore: migrate data proto to v1 #868

merged 11 commits into from
Mar 11, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Mar 9, 2022

Description

Closes: #849

Update data proto to v1 following #708 and retroactively update v1alpha2 to match proto released in v2.0.0-beta1.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review March 9, 2022 19:41
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #868 (90822d3) into master (487df5e) will increase coverage by 0.08%.
The diff coverage is 6.59%.

❗ Current head 90822d3 differs from pull request most recent head 624014a. Consider uploading reports for the commit 624014a to get more accurate results

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   33.19%   33.27%   +0.08%     
==========================================
  Files         185      185              
  Lines       57325    57480     +155     
==========================================
+ Hits        19027    19127     +100     
- Misses      36682    36723      +41     
- Partials     1616     1630      +14     
Flag Coverage Δ
experimental-codecov 33.24% <6.59%> (+0.08%) ⬆️
stable-codecov 29.20% <6.12%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

// ContentHash specifies a hash based content identifier for a piece of data
message ContentHash {
// sum selects the type of content hash
oneof sum {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break amino signing. Maybe we can split them into separate fields (like #790).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a followup task #872

ryanchristo and others added 2 commits March 11, 2022 08:13
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
@ryanchristo ryanchristo enabled auto-merge (squash) March 11, 2022 16:15
@ryanchristo ryanchristo merged commit c0204ad into master Mar 11, 2022
@ryanchristo ryanchristo deleted the ryan/849-data-proto branch March 11, 2022 16:16
@ryanchristo ryanchristo mentioned this pull request Jun 4, 2022
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate data proto files to v1
4 participants