Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update proto version and proto-gen #879

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Conversation

ryanchristo
Copy link
Member

Description

Update proto version and re-enable docker proto-gen.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #879 (4e906bb) into master (53425d5) will increase coverage by 0.21%.
The diff coverage is n/a.

❗ Current head 4e906bb differs from pull request most recent head a955070. Consider uploading reports for the commit a955070 to get more accurate results

@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
+ Coverage   73.84%   74.06%   +0.21%     
==========================================
  Files         173      171       -2     
  Lines       22239    22094     -145     
==========================================
- Hits        16423    16363      -60     
+ Misses       4673     4626      -47     
+ Partials     1143     1105      -38     
Flag Coverage Δ
experimental-codecov 74.03% <ø> (+0.21%) ⬆️
stable-codecov 66.60% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo marked this pull request as ready for review March 15, 2022 02:25
@@ -1399,7 +1399,7 @@ func (x *fastReflection_EventStoreRawData) ProtoMethods() *protoiface.Methods {
// Code generated by protoc-gen-go. DO NOT EDIT.
// versions:
// protoc-gen-go v1.27.0
// protoc v3.19.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if there was a version here rather than (unknown) but this is consistent with the sdk.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not a docker expert, but im wondering if maybe protoc isn't installed in the container? https://grpc.io/docs/protoc-installation/

that protoc version in the -diff is the one i had installed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... protoc is installed as it was on my system. I'm using a later version.

$ protoc --version
libprotoc 3.19.4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a minor detail and the sdk is using the same setup and generates (unkown) as well. Would be nice to get this merged so that we are all generating the same output. Updating the tendermint container is also out of scope for this pull request and not something we can do.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if protoc wouldn't be installed then we wouldn't be able to generate anything, right?

@ryanchristo ryanchristo enabled auto-merge (squash) March 17, 2022 02:14
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left on qustion

@@ -340,7 +340,7 @@ devdoc-update:
### Protobuf ###
###############################################################################

containerProtoVer=v0.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we are not creating our own container?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could create our own container but I think it makes sense to use the tendermint container for now.

@ryanchristo ryanchristo merged commit ab65c32 into master Mar 17, 2022
@ryanchristo ryanchristo deleted the ryan/proto-gen branch March 17, 2022 12:00
@ryanchristo ryanchristo mentioned this pull request Mar 17, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants