Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update class events #855

Merged
merged 7 commits into from
Mar 17, 2022
Merged

feat: update class events #855

merged 7 commits into from
Mar 17, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Mar 8, 2022

Description

adds events for the class update methods

Closes: #831


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo
Copy link
Member

cc @technicallyty is this still a draft or ready for review?

@technicallyty
Copy link
Contributor Author

cc @technicallyty is this still a draft or ready for review?

i was gonna wait for #863

string class_name = 1;

// old_metadata is the metadata before the update.
string old_metadata = 2;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if its worth to have this field, lmk your opinions!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here but including it seems reasonable.

@technicallyty technicallyty marked this pull request as ready for review March 14, 2022 20:28
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #855 (4ff765d) into master (ba24575) will decrease coverage by 50.09%.
The diff coverage is 3.07%.

❗ Current head 4ff765d differs from pull request most recent head 96b8264. Consider uploading reports for the commit 96b8264 to get more accurate results

@@             Coverage Diff             @@
##           master     #855       +/-   ##
===========================================
- Coverage   73.84%   23.75%   -50.10%     
===========================================
  Files         173      189       +16     
  Lines       22239    70924    +48685     
===========================================
+ Hits        16423    16846      +423     
- Misses       4673    52416    +47743     
- Partials     1143     1662      +519     
Flag Coverage Δ
experimental-codecov ?
stable-codecov 23.75% <3.07%> (-43.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

string class_name = 1;

// old_metadata is the metadata before the update.
string old_metadata = 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here but including it seems reasonable.

@ryanchristo
Copy link
Member

Can you rerun make proto on this before merging? I should have done so in #879 and we have an error in the generated proto files on master now.

@technicallyty technicallyty merged commit d871222 into master Mar 17, 2022
@technicallyty technicallyty deleted the ty/831-update_events branch March 17, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add update credit class events
3 participants