-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update class events #855
Conversation
cc @technicallyty is this still a draft or ready for review? |
i was gonna wait for #863 |
string class_name = 1; | ||
|
||
// old_metadata is the metadata before the update. | ||
string old_metadata = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if its worth to have this field, lmk your opinions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion here but including it seems reasonable.
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
===========================================
- Coverage 73.84% 23.75% -50.10%
===========================================
Files 173 189 +16
Lines 22239 70924 +48685
===========================================
+ Hits 16423 16846 +423
- Misses 4673 52416 +47743
- Partials 1143 1662 +519
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
string class_name = 1; | ||
|
||
// old_metadata is the metadata before the update. | ||
string old_metadata = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion here but including it seems reasonable.
Can you rerun make proto on this before merging? I should have done so in #879 and we have an error in the generated proto files on master now. |
Description
adds events for the class update methods
Closes: #831
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change