fix: Use correct REGEN_HOME env in regen sandbox #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanchristo
reviewed
Feb 20, 2023
There was a problem hiding this comment.
Thanks @paul121!
It looks like bootstrap.sh and setup/utils.sh both use REGENHOME. Can you update?
77a4d03 to
e6ec5d4
Compare
|
Thanks @ryanchristo - I missed that. Now it makes more sense how this was working :-) I removed the $ docker run -v $(pwd):/regen regen-sandbox:latest
Created genesis. chain-id: regen-sandbox, moniker: test_moniker
No $REGEN_MNEMONIC provided, using generated mnemonic:
...........removed
Adding key to keyring for account name: addr1
Adding key to keyring for account name: addr2
Adding key to keyring for account name: addr3
Adding key to keyring for account name: addr4
Adding key to keyring for account name: addr5
Setting up validator (from addr1)...
Genesis transaction written to "/regen/.regen/config/gentx/gentx-cb93edeb49841d6c68fabde235f00b9461ea56c3.json"
Collecting gentxs from /regen/.regen/config/gentx into genesis.json
Starting up regen node...
Node started & state inialized!
^C
$ docker run -v $(pwd):/regen regen-sandbox:latest
Regen home (/regen/.regen) already exists, skipping bootstrap...
Starting up regen node...
Node started & state inialized! |
ryanchristo
approved these changes
Feb 21, 2023
|
@Mergifyio backport release/v5.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> (cherry picked from commit 489200c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I believe
REGENHOMEis a semi-incorrect env var for here. I was referenced this regen-sandbox Dockerfile and was getting inconsistent results. It's quite confusing because it seems like it works for some things but not others. UsingREGEN_HOMEis working much better, as seen in this PR: #1672Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change