Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): add and update core state validation #1362

Merged
merged 11 commits into from
Aug 22, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Aug 18, 2022

Description

Ref: #1332

This pull request adds and updates state validation checks and includes those checks in genesis validation.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review August 19, 2022 01:31
@ryanchristo ryanchristo requested a review from a team August 19, 2022 01:31
@ryanchristo ryanchristo changed the title feat(x/ecocredit): add missing core state validation feat(x/ecocredit): add and update core state validation Aug 19, 2022
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@@ -246,6 +246,12 @@ func ValidateGenesis(data json.RawMessage, params core.Params) error {

func validateMsg(m proto.Message) error {
switch m.(type) {
case *api.CreditType:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR. We should also add validation for basket and marketplace messages.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice work 👏🏻

@ryanchristo ryanchristo merged commit 971b3cd into main Aug 22, 2022
@ryanchristo ryanchristo deleted the ryan/1332-state-validation branch August 22, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants