Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing genesis validation checks #1332

Closed
4 tasks
Tracked by #972
ryanchristo opened this issue Aug 3, 2022 · 0 comments · Fixed by #1467
Closed
4 tasks
Tracked by #972

Add missing genesis validation checks #1332

ryanchristo opened this issue Aug 3, 2022 · 0 comments · Fixed by #1467
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Feature New feature or request

Comments

@ryanchristo
Copy link
Member

Summary

When creating a separate genesis package within the ecocredit module and migrating genesis validation checks for batch, class, and project in #1293, I noticed we are missing validation functions for a lot of state objects to be used in genesis validation.

We should make sure we have validation for all state objects. Also, we should prefix the files with state_ (currently types_).

Problem Definition

When creating a new genesis file or validating an exported genesis file, we should be validating all state.

Proposal

Add validate received methods for all state objects and add validation check to genesis validation.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant