-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit): default values for new ORM params #1293
Conversation
@@ -0,0 +1,33 @@ | |||
package core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes here. Moved from core/genesis.go
(and what is now genesis/genesis.go
).
@@ -0,0 +1,33 @@ | |||
package core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes here. Moved from core/genesis.go
(and what is now genesis/genesis.go
).
@@ -0,0 +1,19 @@ | |||
package core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes here. Moved from core/genesis.go
(and what is now genesis/genesis.go
).
@@ -0,0 +1,33 @@ | |||
package core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes here. Moved from core/genesis.go
(and what is now genesis/genesis.go
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #1293 +/- ##
==========================================
- Coverage 77.51% 77.48% -0.03%
==========================================
Files 213 219 +6
Lines 16084 16128 +44
==========================================
+ Hits 12467 12497 +30
+ Misses 2613 2612 -1
- Partials 1004 1019 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* feat(x/ecocredit): default values for new ORM params * fix comment (cherry picked from commit 9a49021)
Description
Closes: #1158
This pull request updates default genesis values to include a default credit type and a default allowed denom to make it easier for starting a local testnet and then testing against that local testnet.
In order to support a default allowed denom (a marketplace type), a separate
genesis
package was created in the root of the module directory (previously incore
- was probably not the right place anyways). Import cycles were violated inmodule
and in the root of the ecocredit module so a separategenesis
package was the simplest solution.Validation functions for class, class issuers, project, and batch were moved to respective type files for each within
core
.Manual tests: https://hackmd.io/WYHeLuIQSKOnLlJVGsFVnw (including upgrade tests just to be sure this does not affect the upgrade although these changes only affect starting a new chain without a genesis file as they should).
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change