fix(types): positive decimal from string must be finite #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1210 +/- ##
==========================================
+ Coverage 70.21% 70.23% +0.02%
==========================================
Files 235 235
Lines 23975 23976 +1
==========================================
+ Hits 16833 16840 +7
Misses 5691 5691
+ Partials 1451 1445 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
aleem1314
reviewed
Jun 27, 2022
aleem1314
approved these changes
Jun 27, 2022
|
Tests? |
We already have tests and they were intermittently failing without this change #1181 |
|
Ah, but I can add a test for |
aaronc
reviewed
Jun 27, 2022
aaronc
reviewed
Jun 27, 2022
types/math/dec_test.go
Outdated
| @@ -552,6 +553,18 @@ func testIsPositive(t *rapid.T) { | |||
| require.Equal(t, f > 0, dec.IsPositive()) | |||
| } | |||
|
|
|||
| // Property: isFinite(f) == isFinite(NewDecFromString(f.String())) | |||
| func testIsFinite(t *rapid.T) { | |||
There was a problem hiding this comment.
no reason to make this a rapid test I don't think. just create a simple unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1181
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change