update test per review comment

regen-network · Jun 27, 2022 · b83eb23 · b83eb23
1 parent 9b8a731
commit b83eb23
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/types/math/dec_test.go b/types/math/dec_test.go
@@ -60,7 +60,6 @@ func TestDec(t *testing.T) {
 	t.Run("TestIsZero", rapid.MakeCheck(testIsZero))
 	t.Run("TestIsNegative", rapid.MakeCheck(testIsNegative))
 	t.Run("TestIsPositive", rapid.MakeCheck(testIsPositive))
-	t.Run("TestIsFinite", rapid.MakeCheck(testIsFinite))
 	t.Run("TestNumDecimalPlaces", rapid.MakeCheck(testNumDecimalPlaces))
 
 	// Unit tests
@@ -553,18 +552,6 @@ func testIsPositive(t *rapid.T) {
 	require.Equal(t, f > 0, dec.IsPositive())
 }
 
-// Property: isFinite(f) == isFinite(NewDecFromString(f.String()))
-func testIsFinite(t *rapid.T) {
-	// genDec always draws from float64
-	a := genDec.Draw(t, "a").(Dec)
-	require.True(t, a.IsFinite())
-
-	b, err := NewDecFromString("NaN")
-	require.NoError(t, err)
-
-	require.False(t, b.IsFinite())
-}
-
 // Property: floatDecimalPlaces(f) == NumDecimalPlaces(NewDecFromString(f.String()))
 func testNumDecimalPlaces(t *rapid.T) {
 	floatAndDec := genFloatAndDec.Draw(t, "floatAndDec").(floatAndDec)
@@ -611,6 +598,18 @@ func floatDecimalPlaces(t *rapid.T, f float64) uint32 {
 	}
 }
 
+func TestIsFinite(t *testing.T) {
+	a, err := NewDecFromString("1.5")
+	require.NoError(t, err)
+
+	require.True(t, a.IsFinite())
+
+	b, err := NewDecFromString("NaN")
+	require.NoError(t, err)
+
+	require.False(t, b.IsFinite())
+}
+
 func TestReduce(t *testing.T) {
 	a, err := NewDecFromString("1.30000")
 	require.NoError(t, err)