refactor(x/ecocredit): update core proto comments and fields #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
Codecov Report
@@ Coverage Diff @@
## master #1161 +/- ##
=========================================
Coverage ? 69.62%
=========================================
Files ? 221
Lines ? 23075
Branches ? 0
=========================================
Hits ? 16065
Misses ? 5623
Partials ? 1387
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Pending #1160 |
|
Some overlap with #1160 but ready for review. |
ryanchristo
commented
Jun 10, 2022
Comment on lines
+23
to
+25
| // basket_fee is a list of basket creation fees accepted when creating a | ||
| // basket. Any fee listed is accepted and charged to the basket creator when | ||
| // creating a basket. |
There was a problem hiding this comment.
This is not the current behavior but should be. See #1165.
ryanchristo
commented
Jun 10, 2022
Comment on lines
+72
to
+76
| // The country-code must be 2 alphabetic characters, the sub-national-code | ||
| // can be 1-3 alphanumeric characters, and the postal-code can be up to 64 | ||
| // alphanumeric characters. Only the country-code is required, while the | ||
| // sub-national-code and postal-code are optional and can be added for | ||
| // increased precision. |
There was a problem hiding this comment.
Removed mention of needing to conform to ISO 3166-2 here and elsewhere given the current implementation does not require this and we want to avoid being political and requiring a protocol update to update accepted countries.
technicallyty
approved these changes
Jun 13, 2022
aleem1314
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #715
This pull request updates proto comments, updates
IssuertoAdmininMsgCreateProject(the address that will become the admin of the project, same asMsgCreateClassand other messages, i.e. we don't useCreatorforMsgCreateClass), movesBatchIssuanceto types, moves and makes use ofCredits, and updatesMsgUpdateCreditClassMetadato useNewMetadatarather thanMetadata(same as other update methods and when updating a project).Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change