Inconsistent implementation of basket fee requirements

[ryanchristo]

Summary

Params.credit_class_fee is a repeated Coin and MsgCreateClass.fee is a single Coin. As currently implemented, a user is able to choose one of the fees listed in credit_class_fee when multiple fees are provided in Params.credit_class_fee.

Params.basket_fee is a repeated Coin and MsgCreateBasket.fee is a repeated Coin. As currently implemented, a user must provide all fees listed in basket_fee when multiple fees are provided in Params.basket_fee.

Problem Definition

Inconsistent implementation of fee parameters. This is not clear in the specification and fee handling should be consistent.

Proposal

Either both should only require one of the fees listed (how credit class creation currently works) or both should require all of the fees listed (how basket creation currently works).

I would even advocate that we migrate away from multiple fees when we implement ORM tables for each of these, we would use a singleton table for a single Coin (see #960 (comment) and #962 (comment)).

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[technicallyty]

+1 for switching basket to the way create class is implemented. I think having to pay a multi-coin fee is a bit awkward UX