refactor(ecocredit): remove credit types from params #1043

technicallyty · 2022-04-20T22:05:57Z

Description

replaces usages of credit types from params to credit types from ORM

Closes: #1016

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

…regen-network/regen-ledger into ty/1005-credit_type_gov_handler

Co-authored-by: Aaron Craelius <aaron@regen.network>

…regen-network/regen-ledger into ty/1005-credit_type_gov_handler

This reverts commit fa42e6d.

…type_params

codecov · 2022-04-22T04:42:40Z

Codecov Report

❗ No coverage uploaded for pull request base (master@dde7c32). Click here to learn what that means.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##             master    #1043   +/-   ##
=========================================
  Coverage          ?   68.81%           
=========================================
  Files             ?      222           
  Lines             ?    21326           
  Branches          ?        0           
=========================================
  Hits              ?    14675           
  Misses            ?     5327           
  Partials          ?     1324

Flag	Coverage Δ
experimental-codecov	`68.81% <83.33%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

technicallyty · 2022-04-22T17:57:58Z

x/ecocredit/client/testsuite/tx.go

@@ -970,7 +1022,7 @@ func (s *IntegrationTestSuite) TestTxSell() {
 			name: "valid",
 			args: append(
 				[]string{
-					fmt.Sprintf("[{batch_denom: \"%s\", quantity: \"5\", ask_price: \"100uregen\", disable_auto_retire: false}]", batchDenom),
+					fmt.Sprintf("[{batch_denom: \"%s\", quantity: \"5\", ask_price: \"100stake\", disable_auto_retire: false}]", batchDenom),


default params use sdk.DefaultBondDenom, so switched to that here.

technicallyty · 2022-04-22T18:01:40Z

x/ecocredit/core/params.go

 		[]*AskDenom{
 			{
-				Denom:        "uregen",
-				DisplayDenom: "regen",
+				Denom:        sdk.DefaultBondDenom,


switched to default bond denom to match the above and make testing more straightforward.

technicallyty · 2022-04-22T18:05:24Z

this PR does not include the additional logic for the upgrade handler, tracking here: #1049

aleem1314 · 2022-04-25T14:18:55Z

x/ecocredit/simulation/genesis.go

@@ -109,7 +109,6 @@ func RandomizedGenState(simState *module.SimulationState) {
 		CreditClassFee:       creditClassFee,
 		AllowedClassCreators: allowedClassCreators,
 		AllowlistEnabled:     allowListEnabled,
-		CreditTypes:          creditTypes,


Without credit-type sims will fail. We should initialize CreditTypeTable with least one credit-type.

aleem1314 · 2022-04-25T14:27:44Z

proto/regen/ecocredit/v1/types.proto

@@ -31,9 +31,6 @@ message Params {
  // creation
  bool allowlist_enabled = 4;

-  // credit_types is a list of definitions for credit types
-  repeated CreditType credit_types = 5;


We should add state migration for this.

Should we add this to #1049 as a followup or add the migrations here?

yeah i wanted to do this as a followup in #1049 😄

A followup is ok with me but let's make sure to add the migrations needed as an item to the issue.

its already got both items for credit types and ask denoms, i might've used the wrong wording though 🤷🏻

ryanchristo

Looking good. A few questions and comments.

ryanchristo · 2022-04-25T17:13:31Z

proto/regen/ecocredit/v1/types.proto

@@ -31,9 +31,6 @@ message Params {
  // creation
  bool allowlist_enabled = 4;

-  // credit_types is a list of definitions for credit types
-  repeated CreditType credit_types = 5;


Should we add this to #1049 as a followup or add the migrations here?

x/ecocredit/client/testsuite/grpc.go

x/ecocredit/core/msg_credit_type.go

x/ecocredit/simulation/params.go

ryanchristo

Nice work! Looks good to me. Let's just make sure the followup issue includes the information about the migrations needing to be updated.

ryanchristo · 2022-04-25T18:05:26Z

proto/regen/ecocredit/v1/types.proto

@@ -31,9 +31,6 @@ message Params {
  // creation
  bool allowlist_enabled = 4;

-  // credit_types is a list of definitions for credit types
-  repeated CreditType credit_types = 5;


A followup is ok with me but let's make sure to add the migrations needed as an item to the issue.

aleem1314

lgtm

ryanchristo · 2022-04-26T15:57:15Z

Looks like post-merge fixes need to be applied.

technicallyty and others added 30 commits April 11, 2022 14:46

chore: gen api

ddfe66c

wip: proposal handler

6393445

wip: wires

2dd5ecc

feat: final gov handler

0c0ddbd

chore: cleanup dead code

b04bb2e

chore: cleanup code

195b51e

Merge branch 'master' into ty/1005-credit_type_gov_handler

bd10a55

chore: fix app error

6d2f020

chore: add dummy REST proposal handler

c2e72a9

chore: regen mocks

8690a08

chore: not invalid request

f99cd38

chore: clean test

0fcb39a

refactor: move proposal handler code into server/core

9cb5970

chore: add tests for new types

e7ab09c

refactor: use setCustomModuleBasics

e10b59b

fix: restore setCustomKeepers

834d836

Update x/ecocredit/server/expected_keepers.go

8f40361

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>

chore: assert credit type name length

af4f04f

refactor: NewCreditType -> AddCreditType

975f386

Merge branch 'ty/1005-credit_type_gov_handler' of https://github.com/…

7cafa8d

…regen-network/regen-ledger into ty/1005-credit_type_gov_handler

Update app/stable_appconfig.go

567325b

Co-authored-by: Aaron Craelius <aaron@regen.network>

chore: import alias

549d53e

Merge branch 'ty/1005-credit_type_gov_handler' of https://github.com/…

d6bf5be

…regen-network/regen-ledger into ty/1005-credit_type_gov_handler

Merge branch 'master' into ty/1005-credit_type_gov_handler

8dfbe96

fix: remove duplicate credit type validate method

eb1b2f5

chore: remove proposal cli method

fa42e6d

Revert "chore: remove proposal cli method"

dddd634

This reverts commit fa42e6d.

chore: revert cli removal

582fec6

Merge branch 'ty/1005-credit_type_gov_handler' into ty/1016-rm_credit…

b840623

…type_params

refactor: remove credit types from params

bfd6dfb

technicallyty added 6 commits April 20, 2022 15:18

chore: remove param change sim for credit types

3b1dcd5

Merge branch 'master' into ty/1016-rm_credittype_params

361847b

fix: duplicate import

eb3b527

chore: fix tests & default params

40e027b

chore: remove credit type test

ba6b117

fix: faililng sim test

bdbaacd

technicallyty marked this pull request as ready for review April 22, 2022 17:55

fix: explicit iterator closing

a96e540

technicallyty commented Apr 22, 2022

View reviewed changes

technicallyty requested review from ryanchristo and aleem1314 April 22, 2022 18:02

aleem1314 reviewed Apr 25, 2022

View reviewed changes

technicallyty added 4 commits April 25, 2022 09:10

Merge branch 'master' into ty/1016-rm_credittype_params

70b79bb

fix: insert credit type in sims

467f7da

Merge branch 'master' into ty/1016-rm_credittype_params

89ba58d

chore: move utils

1dc0e75

ryanchristo reviewed Apr 25, 2022

View reviewed changes

chore: remove param from ParamChanges

3fcdf55

ryanchristo approved these changes Apr 25, 2022

View reviewed changes

aleem1314 approved these changes Apr 26, 2022

View reviewed changes

technicallyty added 2 commits April 26, 2022 07:18

Merge branch 'master' into ty/1016-rm_credittype_params

c252185

Merge branch 'master' into ty/1016-rm_credittype_params

5312f32

fix: ecocreit genesis for integration tests

7adc2fd

ryanchristo merged commit 2a5769a into master Apr 26, 2022

ryanchristo deleted the ty/1016-rm_credittype_params branch April 26, 2022 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(ecocredit): remove credit types from params #1043

refactor(ecocredit): remove credit types from params #1043

technicallyty commented Apr 20, 2022 •

edited by zube bot

Loading

codecov bot commented Apr 22, 2022 •

edited

Loading

technicallyty Apr 22, 2022

technicallyty Apr 22, 2022

technicallyty commented Apr 22, 2022

aleem1314 Apr 25, 2022

technicallyty Apr 26, 2022

aleem1314 Apr 25, 2022

ryanchristo Apr 25, 2022

technicallyty Apr 25, 2022

ryanchristo Apr 25, 2022

technicallyty Apr 25, 2022

ryanchristo left a comment

ryanchristo Apr 25, 2022

ryanchristo left a comment

ryanchristo Apr 25, 2022

aleem1314 left a comment

ryanchristo commented Apr 26, 2022

refactor(ecocredit): remove credit types from params #1043

refactor(ecocredit): remove credit types from params #1043

Conversation

technicallyty commented Apr 20, 2022 • edited by zube bot Loading

Description

Author Checklist

Reviewers Checklist

codecov bot commented Apr 22, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

technicallyty commented Apr 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanchristo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanchristo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aleem1314 left a comment

Choose a reason for hiding this comment

ryanchristo commented Apr 26, 2022

technicallyty commented Apr 20, 2022 •

edited by zube bot

Loading

codecov bot commented Apr 22, 2022 •

edited

Loading