Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove credit types from Params #1016

Closed
4 tasks
Tracked by #818
technicallyty opened this issue Apr 13, 2022 · 0 comments · Fixed by #1043
Closed
4 tasks
Tracked by #818

Remove credit types from Params #1016

technicallyty opened this issue Apr 13, 2022 · 0 comments · Fixed by #1043
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature

Comments

@technicallyty
Copy link
Contributor

technicallyty commented Apr 13, 2022

Summary

following #1015 we should remove credit types from params.

Problem Definition

once #1015 is merged, we will have support for credit types in ORM. We will no longer need them in x/params

Proposal

  • remove credit types from params code
  • update submodule code / util functions to fetch credit types from ORM, not x/params keeper.
  • update tests to not use mock param keeper for credit types (we can just put them in ORM table)
  • gov handler CLI integration test
  • add code to migration to move any existing credit types into ORM storage

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@technicallyty technicallyty self-assigned this Apr 13, 2022
@technicallyty technicallyty added the Scope: x/ecocredit Issues that update the x/ecocredit module label Apr 13, 2022
@ryanchristo ryanchristo added the Type: Refactor A code change that neither fixes a bug nor adds a feature label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants