feat: add amino signing support #69

ryanchristo · 2023-05-23T20:13:25Z

Closes: #10

This pull request adds support for amino signing.

Deploy Preview: https://deploy-preview-69--regen-groups-ui.netlify.app/

netlify · 2023-05-23T20:13:31Z

✅ Deploy Preview for regen-groups-ui ready!

Name	Link
🔨 Latest commit	`fa6f45d`
🔍 Latest deploy log	https://app.netlify.com/sites/regen-groups-ui/deploys/64bfe93b3a7c250008a768ec
😎 Deploy Preview	https://deploy-preview-69--regen-groups-ui.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ryanchristo · 2023-06-13T20:10:24Z

The current setup using getOfflineSignerOnlyAmino works with messages that do not have embedded types but it does not work with creating and updating group policies and submitting proposals. Still investigating.

ryanchristo · 2023-06-13T21:00:31Z

MsgCreateGroupWithPolicy (using new helpers)

Broadcasting transaction failed with code 4 (codespace: sdk). Log: signature verification failed; please verify account number (1), sequence (13) and chain-id (regenlocal): unauthorized

MsgSubmitProposal (not using new helpers)

Broadcasting transaction failed with code 7 (codespace: sdk). Log: msg 0: invalid from address: empty address string is not allowed: invalid address

Updating group name and metadata works as expected.

ryanchristo · 2023-06-13T21:21:37Z

MsgSubmitProposal (not using any helpers and no message)

Broadcasting transaction failed with code 4 (codespace: sdk). Log: signature verification failed; please verify account number (1), sequence (3) and chain-id (regenlocal): unauthorized

Same error as MsgCreateGroupWithPolicy with helpers.

package.json

ryanchristo · 2023-06-15T17:05:45Z

MsgCreateGroupWithPolicy is working after updating metadata fields to not be empty and only if groupPolicyAsAdmin is set to true. It seems the encoding of zero-values is not working correctly. Also, MsgSubmitProposalEncoded type does not exist in the telescope generated code so will need to figure out why and how to proceed.

src/api/group.messages.ts

ryanchristo · 2023-07-03T23:57:13Z

This is currently working with all group messages but the project won't build due to typescript errors.

ryanchristo · 2023-07-12T23:14:56Z

I think we should manually fix the typescript errors upstream (regen-network/regen-js#79) and tag a new version of the api package that we can use until we resolve the issues in telescope and/or regen-js.

I think it's ok if the changes get overwritten as we can always pull them back in if we need to tag a new release of the api package that will be used in the groups ui. I'd like to at least have a version we know can use for the MVP and I think rewriting the code we are importing from @regen-network/api/src is too much to reproduce in this repo.

ryanchristo · 2023-07-12T23:31:30Z

If we decide to merge regen-network/regen-js#79, I'll tag another release and update and then open for review.

ryanchristo · 2023-07-13T16:57:44Z

This is now ready to review.

ryanchristo · 2023-07-13T19:43:13Z

And follow up issue created #105.

blushi · 2023-07-18T13:16:54Z

I'm getting an error when editing group:
Broadcasting transaction failed with code 4 (codespace: sdk). Log: signature verification failed; please verify account number (12), sequence (1866) and chain-id (regen-redwood-1): unauthorized

ryanchristo · 2023-07-18T18:44:04Z

Oof. Looking into it. Also noticed the update group messages need to be added. Will fix and add.

ryanchristo · 2023-07-18T22:53:56Z

The new messages require a new file from the api src directory so we may need to manually resolve and release a version with the manual fixes upstream...

ryanchristo · 2023-07-18T22:56:30Z

Also running into issues now with submitting proposals with the following messages:

MsgUpdateGroupMembers
MsgUpgradeGroupPolicyDecisionPolicy

blushi · 2023-07-25T08:52:32Z

Working now with a MsgUpdateGroupMembers proposal.

But I still get the following error when trying to create a proposal with MsgUpdateGroupDecisionPolicy as soon as I have a percentage decision policy:

Proposal could not be created:
Broadcasting transaction failed with code 10 (codespace: math). Log: msg 0: decision policy: threshold: parse mantissa: : invalid decimal string: invalid decimal string

Here's a fix: #116

blushi

pre-approving, good to merge after final testing

…116)

ryanchristo · 2023-07-25T16:41:43Z

pre-approving, good to merge after final testing

Ran through submit proposal messages one more time with each supported message (and no messages) on redwood:

https://deploy-preview-69--regen-groups-ui.netlify.app/37

feat: add amino signing support

d79e95d

ryanchristo added 3 commits June 12, 2023 14:41

Merge branch 'main' into ryan/10-amino-signing-support

aabd1da

encoded msg and comments

98d80ad

auto or only amino

18acc7c

ryanchristo commented Jun 13, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

ryanchristo added 3 commits June 14, 2023 20:48

metadata whitepace

9793b17

policy as admin todo

6e51ea2

todo and format

c524286

ryanchristo mentioned this pull request Jun 15, 2023

helpers for nested create Any objects hyperweb-io/telescope#281

Open

2 tasks

ryanchristo added 4 commits June 15, 2023 10:21

Merge branch 'main' into ryan/10-amino-signing-support

6927a41

bump regen api version

788256c

update create group policy

23bda00

vote metadata and todo

4f07e1f

ryanchristo changed the title ~~feat: #10 add amino signing support~~ feat: add amino signing support Jun 16, 2023

update notes and todos

cda072a

ryanchristo requested a review from blushi June 16, 2023 19:16

blushi reviewed Jun 21, 2023

View reviewed changes

src/api/group.messages.ts Outdated Show resolved Hide resolved

ryanchristo added 2 commits June 28, 2023 17:26

fix create group with policy

85de73e

fix vote on proposal

f5c3bea

ryanchristo force-pushed the ryan/10-amino-signing-support branch from 96f220c to f5c3bea Compare June 29, 2023 04:55

ryanchristo changed the base branch from main to dev July 3, 2023 19:04

ryanchristo added 3 commits July 3, 2023 16:03

fix group amino converters

82912bd

fix group amino converters

37e6dc8

fix group amino converters

a4189bb

ryanchristo added 3 commits July 10, 2023 10:27

Merge branch 'dev' into ryan/10-amino-signing-support

e2ec043

Merge branch 'dev' into ryan/10-amino-signing-support

e0db481

fix internal typescript error

57173db

ryanchristo requested a review from a team July 12, 2023 23:29

bump api package and cleanup

29e58c4

ryanchristo marked this pull request as ready for review July 13, 2023 16:52

ryanchristo mentioned this pull request Jul 13, 2023

Remove amino converter workaround #105

Open

update comments and todos

335c7d6

Merge branch 'dev' into ryan/10-amino-signing-support

5788aea

ryanchristo marked this pull request as draft July 18, 2023 19:55

fix and add amino converters to workaround

a08e5d5

ryanchristo mentioned this pull request Jul 19, 2023

fix: minimal ts errors for groups-ui regen-network/regen-js#87

Merged

ryanchristo added 3 commits July 24, 2023 13:14

fix update decision policy proposal

de9fe9f

fix update group members proposal

04d9932

bump api package version

8cb810a

ryanchristo marked this pull request as ready for review July 24, 2023 20:38

blushi approved these changes Jul 25, 2023

View reviewed changes

fix: MsgSubmitProposal with update decision policy toAmino converter (#…

fa6f45d

…116)

ryanchristo merged commit 9dead2b into dev Jul 25, 2023

ryanchristo deleted the ryan/10-amino-signing-support branch July 25, 2023 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add amino signing support #69

feat: add amino signing support #69

ryanchristo commented May 23, 2023 •

edited

Loading

netlify bot commented May 23, 2023 •

edited

Loading

ryanchristo commented Jun 13, 2023 •

edited

Loading

ryanchristo commented Jun 13, 2023 •

edited

Loading

ryanchristo commented Jun 13, 2023

ryanchristo commented Jun 15, 2023 •

edited

Loading

ryanchristo commented Jul 3, 2023

ryanchristo commented Jul 12, 2023 •

edited

Loading

ryanchristo commented Jul 12, 2023

ryanchristo commented Jul 13, 2023

ryanchristo commented Jul 13, 2023 •

edited

Loading

blushi commented Jul 18, 2023

ryanchristo commented Jul 18, 2023

ryanchristo commented Jul 18, 2023

ryanchristo commented Jul 18, 2023

blushi commented Jul 25, 2023

blushi left a comment

ryanchristo commented Jul 25, 2023

feat: add amino signing support #69

feat: add amino signing support #69

Conversation

ryanchristo commented May 23, 2023 • edited Loading

netlify bot commented May 23, 2023 • edited Loading

✅ Deploy Preview for regen-groups-ui ready!

ryanchristo commented Jun 13, 2023 • edited Loading

ryanchristo commented Jun 13, 2023 • edited Loading

ryanchristo commented Jun 13, 2023

ryanchristo commented Jun 15, 2023 • edited Loading

ryanchristo commented Jul 3, 2023

ryanchristo commented Jul 12, 2023 • edited Loading

ryanchristo commented Jul 12, 2023

ryanchristo commented Jul 13, 2023

ryanchristo commented Jul 13, 2023 • edited Loading

blushi commented Jul 18, 2023

ryanchristo commented Jul 18, 2023

ryanchristo commented Jul 18, 2023

ryanchristo commented Jul 18, 2023

blushi commented Jul 25, 2023

blushi left a comment

Choose a reason for hiding this comment

ryanchristo commented Jul 25, 2023

ryanchristo commented May 23, 2023 •

edited

Loading

netlify bot commented May 23, 2023 •

edited

Loading

ryanchristo commented Jun 13, 2023 •

edited

Loading

ryanchristo commented Jun 13, 2023 •

edited

Loading

ryanchristo commented Jun 15, 2023 •

edited

Loading

ryanchristo commented Jul 12, 2023 •

edited

Loading

ryanchristo commented Jul 13, 2023 •

edited

Loading