Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up & test amino types & signing #10

Closed
Tracked by #85
haveanicedavid opened this issue Mar 28, 2023 · 6 comments · Fixed by #69
Closed
Tracked by #85

Set up & test amino types & signing #10

haveanicedavid opened this issue Mar 28, 2023 · 6 comments · Fixed by #69
Assignees
Labels
dev Engineering task enhancement New feature or request

Comments

@haveanicedavid
Copy link
Contributor

Amino signing hasn't been tested, and there are likely issues with how it functions. Need to set up & test with ledger

@blushi
Copy link
Member

blushi commented May 13, 2023

Hey team! Please add your planning poker estimate with Zenhub @haveanicedavid @ryanchristo

@ryanchristo
Copy link
Member

Most of this work will need to happen in the regen-js repository. Telescope has an option for amino configuration. This issue is still relevant for groups-ui specifically but I'll open an issue in regen-js to configure amino types.

@ryanchristo
Copy link
Member

Issue in regen-js created: regen-network/regen-js#70

@ryanchristo ryanchristo added the enhancement New feature or request label May 19, 2023
@ryanchristo ryanchristo self-assigned this May 23, 2023
@ryanchristo
Copy link
Member

ryanchristo commented May 23, 2023

Group amino types in regen-js appear to be already registered and registered correctly, so this might not be dependent on the regen-js issue. Currently testing with a ledger device produces the following error:

Screenshot from 2023-05-23 12-55-55

Updating keplr.getOfflineSigner(chainId) to keplr.getOfflineSignerOnlyAmino(chainId) produces the following error when using a ledger device:

Screenshot from 2023-05-23 13-02-14

And with the update without using a ledger device:

Screenshot from 2023-05-23 13-06-18

@ryanchristo
Copy link
Member

Looks like the above may be due to the amino type for ThresholdDecisionPolicy specifically.

type: cosmos-sdk/MsgCreateGroupWithPolicy
value:
  admin: regen1jx34255cgvxpthkg572ma6rhq6crwl6x2s4ajx
  decision_policy:
    type_url: /cosmos.group.v1.ThresholdDecisionPolicy
    value:
      '0': 10
      '1': 1
      '2': 49
      '3': 18
      '4': 16
      '5': 10
      '6': 8
      '7': 8
      '8': 128
      '9': 163
      '10': 5
      '11': 16
      '12': 128
      '13': 163
      '14': 5
      '15': 18
      '16': 4
      '17': 8
      '18': 1
      '19': 16
      '20': 1
  group_metadata: >-
    {"name":"Foo Bar","description":"","forumLink":"","updatedAt":"Tue May 30
    2023 10:44:17 GMT-0700 (Pacific Daylight Time)","other":""}
  group_policy_as_admin: true
  group_policy_metadata: ''
  members:
    - address: regen1l2pwmzk96ftmmt5egpjulyqtneygmmzndf7csk
      metadata: ''
      weight: '1'

@ryanchristo
Copy link
Member

Looks like this is a known issue and may have been resolved...

hyperweb-io/telescope#281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Engineering task enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants