-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruff, pre-commit, and format existing files #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ruff, pre-commit, and format existing files
bmaranville
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paul reviewed this
glass-ships
added a commit
that referenced
this pull request
Sep 12, 2024
* Add ruff, pre-commit, and format existing files * oops, we use bumps@master now * Run formatting * move deps into optional dev group, add webview optional group, update workflows * add back python -m * update gitignore * remove ref webview * update workflows a bit * remove python 3.7 from publish * add extra versions to test against * add build * update min to python 3.9 * update min to python 3.9 --------- Co-authored-by: glass-ships <glass.ships@outlook.com>
glass-ships
added a commit
that referenced
this pull request
Sep 12, 2024
This reverts commit 00cfbeb.
@glass-ships any chance you could add some instructions for installing the pre-commit hooks for developers, in |
Yeah, I'm working on updating some documentation now actually, I'll be sure to include that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.