Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff, pre-commit, and format existing files #184

Merged
merged 15 commits into from
Sep 11, 2024
Merged

Add ruff, pre-commit, and format existing files #184

merged 15 commits into from
Sep 11, 2024

Conversation

mdoucet
Copy link
Contributor

@mdoucet mdoucet commented Sep 11, 2024

No description provided.

Copy link
Member

@bmaranville bmaranville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paul reviewed this

@bmaranville bmaranville merged commit 7230d75 into master Sep 11, 2024
11 of 12 checks passed
glass-ships added a commit that referenced this pull request Sep 12, 2024
* Add ruff, pre-commit, and format existing files

* oops, we use bumps@master now

* Run formatting

* move deps into optional dev group, add webview optional group, update workflows

* add back python -m

* update gitignore

* remove ref webview

* update workflows a bit

* remove python 3.7 from publish

* add extra versions to test against

* add build

* update min to python 3.9

* update min to python 3.9

---------

Co-authored-by: glass-ships <glass.ships@outlook.com>
glass-ships added a commit that referenced this pull request Sep 12, 2024
@bmaranville
Copy link
Member

@glass-ships any chance you could add some instructions for installing the pre-commit hooks for developers, in doc/getting_started/contributing.rst ?

@glass-ships
Copy link
Member

Yeah, I'm working on updating some documentation now actually, I'll be sure to include that

@glass-ships glass-ships deleted the webview branch November 20, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants