Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff, pre-commit, and format existing files #182

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Add ruff, pre-commit, and format existing files #182

merged 10 commits into from
Sep 11, 2024

Conversation

glass-ships
Copy link
Member

@glass-ships glass-ships commented Sep 9, 2024 •
edited
Loading

  • Add ruff as a dependency
  • Add a Makefile, with linting and formatting as targets
  • Add pre-commit config to automate this process

Linting will probably be done as a separate PR to keep this (already quite large) PR more focused

@mdoucet mdoucet merged commit 763cb05 into reflectometry:webview Sep 11, 2024
@glass-ships glass-ships deleted the webview-formatting branch September 11, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkienzle pkienzle Awaiting requested review from pkienzle

@bmaranville bmaranville Awaiting requested review from bmaranville

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glass-ships @mdoucet @pkienzle