Webview #181
Webview #181
Conversation
…colors will not match for polarized plots)
…g panel state between switches
…nt line indicator
|
Tests are passing locally. Need to do some fiddling with github actions so that it doesn't try running old refl1d against new bumps. |
|
Still need a code review of all the changes |
|
|
||
| def _draw_overplot(group, index, label): | ||
| def _draw_overplot(group, index, label, axes=None): |
There was a problem hiding this comment.
Passing fig and axes around everywhere (here and in bumps) is tedious.
| self.version = __version__ if version is None else version | ||
| if auto_tag: | ||
| tag_all(self.probe.parameters(), 'probe') | ||
| tag_all(self.sample.parameters(), 'sample') |
There was a problem hiding this comment.
For simplicity I collapse the parameters into a flat list when I walk the model in bumps. Maybe this tagging could happen during flattening?
There was a problem hiding this comment.
What would be gained by doing the tagging during flattening? You would have to keep track of the "auto_tag" setting (it would become part of the state of the class).
There was a problem hiding this comment.
If every application using bumps serialization needs tagging, then tagging is a bumps concern, not an application concern. [Not that I know what tagging does, but it doesn't seem like it would be specific to reflectometry.]
|
I think I can fix the errors by replacing Feel free to rename the branch from |
update to the webview branch