Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add directory-named-babel-plugin #807

Closed
wants to merge 1 commit into from
Closed

[WIP] Add directory-named-babel-plugin #807

wants to merge 1 commit into from

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Jul 8, 2020

This PR stubs out some of what adding the directory-named-babel-plugin (plan of attack in #641) would entail.

Once added, given two services, contacts and notes, we can import from the directory instead of the file. Here's a diff of the actual vs the intended behavior:

// api/src/services/notes/notes.js

-import { contacts } from 'src/services/contacts/contacts
+import { contacts } from 'src/services/contacts'

Related issues:

@jtoar jtoar added kind/improvement topic/config Babel, Webpack, ESLint, Prettier, etc. labels Jul 8, 2020
@peterp
Copy link
Contributor

peterp commented Jul 28, 2020

Hey @jtoar, would you mind if I take over this PR?

@jtoar
Copy link
Contributor Author

jtoar commented Jul 28, 2020

@peterp Go for it!

@peterp
Copy link
Contributor

peterp commented Sep 7, 2020

Thanks for this @jtoar! 🙇‍♂️

Closing in favour of: #1102

@peterp peterp closed this Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/config Babel, Webpack, ESLint, Prettier, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants