Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for image component on podman #6577

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6488

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

valaparthvi and others added 4 commits February 8, 2023 17:15
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Armel Soro <asoro@redhat.com>
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Feb 8, 2023
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi valaparthvi force-pushed the 6488-support-for-image-comp-on-podman branch from 95eff27 to d9ba058 Compare February 8, 2023 11:49
@openshift-ci openshift-ci bot requested review from feloy and kadel February 8, 2023 11:49
@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 95eff27
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63e38c2cd005c80008d2f352
😎 Deploy Preview https://deploy-preview-6577--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit b1c8e3c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63e3b0a7fd95210008a28003

@odo-robot
Copy link

odo-robot bot commented Feb 8, 2023

OpenShift Unauthenticated Tests on commit 291e48c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 8, 2023

NoCluster Tests on commit 291e48c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 8, 2023

Unit Tests on commit 291e48c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 8, 2023

Validate Tests on commit 291e48c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 8, 2023

Kubernetes Tests on commit 291e48c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 8, 2023

Windows Tests (OCP) on commit 291e48c finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 8, 2023

OpenShift Tests on commit 291e48c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 8, 2023

Kubernetes Docs Tests on commit 9714967 finished successfully.
View logs: TXT HTML

valaparthvi and others added 3 commits February 8, 2023 18:50
Co-authored-by: Armel Soro <armel@rm3l.org>
Co-authored-by: Armel Soro <armel@rm3l.org>
@rm3l rm3l closed this Feb 8, 2023
@rm3l rm3l reopened this Feb 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 8, 2023
@rm3l
Copy link
Member

rm3l commented Feb 8, 2023

/override windows-integration-test/Windows-test

Flaky test.

@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ad77fe7 into redhat-developer:main Feb 8, 2023
@rm3l rm3l mentioned this pull request Mar 10, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Image component for odo dev on podman
3 participants