Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Image component for odo dev on podman #6488

Closed
Tracked by #6578
valaparthvi opened this issue Jan 13, 2023 · 0 comments · Fixed by #6577
Closed
Tracked by #6578

Support Image component for odo dev on podman #6488

valaparthvi opened this issue Jan 13, 2023 · 0 comments · Fixed by #6577
Assignees
Labels
area/odo-on-podman Issues or PRs related to running odo against Podman kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation pair programming Issue that is a good candidate for pair programming sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Milestone

Comments

@valaparthvi
Copy link
Contributor

/kind feature

Which functionality do you think we should add?

odo dev on podman currently does not support building images from the devfile Image component.

Why is this needed?

This feature can be useful if you require the built image for your containers, so a Devfile like below could use this feature.

devfile.yaml
schemaVersion: 2.2.0
metadata:
  name: nodejs
variables:
  CONTAINER_IMAGE: quay.io/unknown-account/myimage

components:
  - container:
      endpoints:
        - name: http-3000
          targetPort: 3000
        - name: tcp-5858
          targetPort: 5858
      env:
      - name: DEBUG_PORT_PROJECT
        value: "5858"
      image: "{{CONTAINER_IMAGE}}"
    name: runtime

  - name: image-build-component
    image:
      imageName: "{{CONTAINER_IMAGE}}"
      dockerfile:
        uri: ./Dockerfile

commands:
  - id: build-image
    apply:
      component: image-build-component

  - id: install
    exec:
      commandLine: npm install
      component: runtime
      workingDir: /projects

  - id: start
    exec:
      workingDir: /projects
      commandLine: npm start
      component: runtime

  - id: build
    exec:
      commandLine: npm install
      component: runtime
      workingDir: ${PROJECT_SOURCE}
      group:
        isDefault: true
        kind: build

  - id: run
    composite:
      commands:
        - build-image
        - start
      group:
        isDefault: true
        kind: run
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jan 13, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jan 13, 2023
@rm3l rm3l added this to odo Project Jan 13, 2023
@valaparthvi valaparthvi added the area/odo-on-podman Issues or PRs related to running odo against Podman label Jan 13, 2023
@valaparthvi valaparthvi removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jan 24, 2023
@valaparthvi valaparthvi added sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint. pair programming Issue that is a good candidate for pair programming labels Jan 25, 2023
@rm3l rm3l added this to the v3.7.0 🚀 milestone Jan 30, 2023
@rm3l rm3l moved this to In Review 👀 in odo Project Feb 8, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in odo Project Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/odo-on-podman Issues or PRs related to running odo against Podman kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation pair programming Issue that is a good candidate for pair programming sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants