Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable use of ImageStreams on OpenShift #6406

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Enable use of ImageStreams on OpenShift #6406

merged 2 commits into from
Dec 15, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Dec 13, 2022

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6376

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Dec 13, 2022
@feloy feloy requested a review from rm3l December 13, 2022 15:32
@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 4c453f7
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/639aed39dc146c00085c1d03
😎 Deploy Preview https://deploy-preview-6406--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@feloy feloy requested a review from kadel December 13, 2022 15:33
@openshift-ci openshift-ci bot requested a review from rnapoles-rh December 13, 2022 15:33
@feloy feloy closed this Dec 13, 2022
@feloy feloy reopened this Dec 13, 2022
@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022 •
edited
Loading

OpenShift Tests on commit b7475fd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022 •
edited
Loading

NoCluster Tests on commit b7475fd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022 •
edited
Loading

Unit Tests on commit b7475fd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022 •
edited
Loading

Validate Tests on commit b7475fd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022 •
edited
Loading

Kubernetes Tests on commit b7475fd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022 •
edited
Loading

Windows Tests (OCP) on commit b7475fd finished successfully.
View logs: TXT HTML

@feloy feloy removed the request for review from rnapoles-rh December 13, 2022 17:48
@feloy feloy closed this Dec 14, 2022
@feloy feloy reopened this Dec 14, 2022
@feloy feloy closed this Dec 14, 2022
@feloy feloy reopened this Dec 14, 2022
rm3l
rm3l requested changes Dec 14, 2022
View reviewed changes
pkg/devfile/adapters/kubernetes/component/adapter.go
@@ -389,6 +389,7 @@ func (a *Adapter) createOrUpdateComponent(

annotations := make(map[string]string)
odolabels.SetProjectType(annotations, component.GetComponentTypeFromDevfileMetadata(a.AdapterContext.Devfile.Data.GetMetadata()))
odolabels.AddCommonAnnotations(annotations)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it also make sense to add this annotation to resources created by odo deploy as well?
Unless I've missed something, it seems this annotation is only added to resources created by odo dev.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadel WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems not possible to create a component from odo deploy for now:
#6376 (comment)

@feloy feloy requested a review from rm3l December 15, 2022 08:23
@feloy feloy force-pushed the feature-6376/imagestream-resolving branch from 78b0cfb to 4c453f7 Compare December 15, 2022 09:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 15, 2022
@feloy
Copy link
Contributor Author

feloy commented Dec 15, 2022

/override ci/prow/v4.11-integration-e2e
Unrelated flaky e2e test

@openshift-ci
Copy link

openshift-ci bot commented Dec 15, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Unrelated flaky e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6ed1287 into redhat-developer:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

By default enable ImageStream resolving
3 participants
@feloy @rm3l @openshift-merge-robot