Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default enable ImageStream resolving #6376

Closed
2 tasks
kadel opened this issue Dec 5, 2022 · 3 comments · Fixed by #6406
Closed
2 tasks

By default enable ImageStream resolving #6376

kadel opened this issue Dec 5, 2022 · 3 comments · Fixed by #6406
Assignees
Labels
kind/user-story An issue of user-story kind
Milestone

Comments

@kadel
Copy link
Member

kadel commented Dec 5, 2022

/kind user-story

User Story

As an odo user, I want to be able to use ImageStreams on OpenShift So that I can use my images hosted on the internal OpenShift registry.

Acceptance Criteria

/kind user-story

@openshift-ci openshift-ci bot added the kind/user-story An issue of user-story kind label Dec 5, 2022
@rm3l rm3l added this to odo Project Dec 5, 2022
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Dec 5, 2022
@valaparthvi valaparthvi removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Dec 8, 2022
@feloy feloy self-assigned this Dec 13, 2022
@rm3l rm3l added this to the v3.5.0 🚀 milestone Dec 13, 2022
@feloy feloy moved this to In Review 👀 in odo Project Dec 14, 2022
@feloy
Copy link
Contributor

feloy commented Dec 14, 2022

It should also be done for Deployment created for a Component in Deploy mode

@feloy feloy moved this from In Review 👀 to In Progress 🚧 in odo Project Dec 14, 2022
@feloy
Copy link
Contributor

feloy commented Dec 14, 2022

It should also be done for Deployment created for a Component in Deploy mode

It seems this is not possible for the moment to deploy a container component in Deploy mode :

  • ✗ exec command is not implemented for Deploy
  • when creating an Apply command for Deploy pointing to a container component, nothing happens

@rm3l
Copy link
Member

rm3l commented Dec 15, 2022

It should also be done for Deployment created for a Component in Deploy mode

It seems this is not possible for the moment to deploy a container component in Deploy mode :

  • ✗ exec command is not implemented for Deploy

I updated the description of #5701 to make sure we do not forget to also add this annotation when this is implemented.

  • when creating an Apply command for Deploy pointing to a container component, nothing happens

I guess that's a different issue, but it's not clear to me what the behavior is supposed to be here.
@kadel ?
When looking at the Devfile spec, I can see that:

Use the the apply command to apply a given component definition, usually a kubernetes, openshift or an image component. Apply commands are also typically bound to preStart and postStop events.
For example, when an apply command is bound to a preStart event, and references a container component, it will start the container as a K8S initContainer in the devworkspace POD, unless the component has its dedicatedPod field set to true.

Repository owner moved this from In Progress 🚧 to Done ✅ in odo Project Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story An issue of user-story kind
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants