Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a generic --run-on flag #6187

Merged
merged 7 commits into from
Oct 6, 2022
Merged

Support a generic --run-on flag #6187

merged 7 commits into from
Oct 6, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Oct 3, 2022 •
edited
Loading

What type of PR is this:

/kind feature

What does this PR do / why we need it:

  • adds a new generic option --run-on.
  • ctx is passed to Complete and Validate methods
  • the presence of the -o json flag is saved in the ctx passed to Complete, Validate and Run
  • the value of the --run-on flag is saved in the ctx passed to Complete, Validate and Run

Which issue(s) this PR fixes:

Fixes #6185

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Oct 3, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 1fed3dc
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/633c6cc692a8dd0008e09223

@feloy feloy requested review from rm3l and valaparthvi October 3, 2022 13:23
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Oct 3, 2022
@openshift-ci openshift-ci bot requested a review from dharmit October 3, 2022 13:24
@feloy feloy removed the request for review from dharmit October 3, 2022 13:24
@odo-robot
Copy link

odo-robot bot commented Oct 3, 2022 •
edited
Loading

Unit Tests on commit b808db6 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 3, 2022 •
edited
Loading

Validate Tests on commit b808db6 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 3, 2022 •
edited
Loading

OpenShift Tests on commit b808db6 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 3, 2022 •
edited
Loading

Kubernetes Tests on commit b808db6 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 4, 2022 •
edited
Loading

Windows Tests (OCP) on commit b808db6 finished successfully.
View logs: TXT HTML

@feloy feloy closed this Oct 4, 2022
@feloy feloy reopened this Oct 4, 2022
rm3l
rm3l requested changes Oct 4, 2022
View reviewed changes
@feloy feloy closed this Oct 4, 2022
@feloy feloy reopened this Oct 4, 2022
@feloy feloy force-pushed the feature-6185/run-on branch from 99dc940 to ff57f10 Compare October 4, 2022 08:55
@feloy feloy requested a review from rm3l October 4, 2022 08:55
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 4, 2022
@feloy feloy force-pushed the feature-6185/run-on branch from ff57f10 to 1fed3dc Compare October 4, 2022 17:26
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2022

New changes are detected. LGTM label has been removed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 5, 2022
@valaparthvi
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 6, 2022
@feloy
Copy link
Contributor Author

feloy commented Oct 6, 2022

/override ci/prow/v4.11-integration-e2e
Pass on IBMCloud

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Pass on IBMCloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1b552e0 into redhat-developer:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept a --run-on flag
4 participants
@feloy @valaparthvi @rm3l @openshift-merge-robot