Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept a --run-on flag #6185

Closed
Tracked by #5871
feloy opened this issue Oct 3, 2022 · 0 comments · Fixed by #6187
Closed
Tracked by #5871

Accept a --run-on flag #6185

feloy opened this issue Oct 3, 2022 · 0 comments · Fixed by #6187
Assignees
@feloy
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Milestone
v3.1.0 🚀

Comments

@feloy
Copy link
Contributor

feloy commented Oct 3, 2022 •
edited
Loading

/kind feature

Which functionality do you think we should add?

odo should accept a run-on flag generically, in the same way it accepts a -o flag.

The value of the flag can be either cluster or podman

The value of the flag should be passed in the ctx received by Run (and make Complete and Validate receive this ctx too).

Why is this needed?

The generic code (genericlioptions.GenericRun) needs to know the targeted platform to inject the correct package (podman of kubernetes) during dependency injection.

Part of #6151
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Oct 3, 2022
This was referenced Oct 3, 2022
Closed
Merged
@feloy feloy self-assigned this Oct 3, 2022
@feloy feloy added this to odo v3.0.0 Oct 3, 2022
@feloy feloy moved this to For Review in odo v3.0.0 Oct 3, 2022
@rm3l rm3l added this to the v3.1.0 🚀 milestone Oct 3, 2022
@rm3l rm3l added this to odo Project Oct 3, 2022
@rm3l rm3l moved this to In Review 👀 in odo Project Oct 3, 2022
@feloy feloy mentioned this issue Oct 4, 2022
Closed
25 tasks
@rm3l rm3l mentioned this issue Oct 6, 2022
Closed
Repository owner moved this from In Review 👀 to Done ✅ in odo Project Oct 6, 2022
Repository owner moved this from For Review to Done in odo v3.0.0 Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects
odo Project
Archived in project
odo v3.0.0
Status: Done
Milestone
v3.1.0 🚀
Development

Successfully merging a pull request may close this issue.

Support a generic --run-on flag feloy/odo
2 participants
@rm3l @feloy