Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify pkg/devfile/adapters/... packages #5914

Merged
merged 12 commits into from
Jul 6, 2022
Merged

Simplify pkg/devfile/adapters/... packages #5914

merged 12 commits into from
Jul 6, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jul 4, 2022

What type of PR is this:

/kind cleanup

What does this PR do / why we need it:

Simplify pkg/devfile/adapters packages (see commits messages for more details)

Which issue(s) this PR fixes:

Cleanup code for #5867

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jul 4, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 29d506b
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62c2e839e130da0008dcefca

@openshift-ci
Copy link

openshift-ci bot commented Jul 4, 2022

@feloy: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this:

/kind cleanup

What does this PR do / why we need it:

Simplify pkg/devfile/adapters packages (see commits messages for more details)

Which issue(s) this PR fixes:

Cleanup code for #5867

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy feloy changed the title Feature 5867/cleanup devfile adapters Simplify pkg/devfile/adapters packages Jul 4, 2022
@openshift-ci openshift-ci bot requested review from cdrage and rnapoles-rh July 4, 2022 10:25
@odo-robot
Copy link

odo-robot bot commented Jul 4, 2022 •
edited
Loading

Unit Tests on commit 86b40f1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 4, 2022 •
edited
Loading

Windows Tests (OCP) on commit 86b40f1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 4, 2022 •
edited
Loading

Kubernetes Tests on commit 86b40f1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 4, 2022 •
edited
Loading

OpenShift Tests on commit 86b40f1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 4, 2022 •
edited
Loading

Validate Tests on commit 86b40f1 finished successfully.
View logs: TXT HTML

@feloy feloy requested review from dharmit, rm3l and valaparthvi and removed request for cdrage and rnapoles-rh July 4, 2022 11:01
@feloy feloy changed the title Simplify pkg/devfile/adapters packages Simplify pkg/devfile/adapters/... packages Jul 4, 2022
rm3l
rm3l requested changes Jul 4, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment about some function doc, but LGTM.
The narrative was easy to review overall by reading each commit in order. Thanks.

@feloy @rm3l
Update pkg/devfile/adapters/kubernetes/component/adapter.go
29d506b 
Co-authored-by: Armel Soro <armel@rm3l.org>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 4, 2022
@rm3l
Copy link
Member

rm3l commented Jul 6, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 6, 2022
@feloy feloy mentioned this pull request Jul 6, 2022
Merged
3 tasks
@feloy
Copy link
Contributor Author

feloy commented Jul 6, 2022

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/unit, ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit a0b0d0f into redhat-developer:main Jul 6, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@feloy @rm3l @cdrage
Simplify pkg/devfile/adapters/... packages (redhat-developer#5914)
a11dee4 
* Remove dependency on common.AdapterContext for sync.Adapter

* Simplify adapters.NewComponentAdapter

* NewComponentAdapter accepts kubernetes.KubernetesContext instead of interface{}

* Replace KubernetesContext with its only field Namespace

* Move the Push Interface and  builders to the kubernetes.component  package

* Move AdapterContext to kubernetes.component package

* Embeds component.New into NewKubernetesAdapter

* Move GetCommandsMap where it is used

* Move GetSyncFilesFromAttributes  where it is used

* Move constants where they are used

* Move types to adapters package

* Update pkg/devfile/adapters/kubernetes/component/adapter.go

Co-authored-by: Armel Soro <armel@rm3l.org>

Co-authored-by: Armel Soro <armel@rm3l.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@dharmit dharmit Awaiting requested review from dharmit

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feloy @rm3l