Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo dev: react to changes as soon as possible #5867

Closed
6 tasks
rm3l opened this issue Jun 23, 2022 · 4 comments · Fixed by #5933
Closed
6 tasks

odo dev: react to changes as soon as possible #5867

rm3l opened this issue Jun 23, 2022 · 4 comments · Fixed by #5933
Assignees
Labels
kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).

Comments

@rm3l
Copy link
Member

rm3l commented Jun 23, 2022

/kind user-story

User Story

  • As an odo user
  • I want to make changes to my source code and Devfile (or even external cluster resources)
  • So that the changes are considered as soon as possible

Acceptance Criteria

  • It should handle Devfile changes when a Pod is in an Error state
  • It should not wait for a specific state in the reconcile loop
  • It should watch for all interesting resources (Deployment, ServiceBindings, ...) permanently, i.e. as long as odo dev is running
  • It should notify users of the current application state
  • If odo dev is running with the no-watch flag, it should not watch for files but still continue to watch cluster resources
  • It should wait until the container is listening on the intended port before stating the application is ready (see odo dev port forward timeouts if app is not ready #5877) => tracked in odo dev port forward timeouts if app is not ready #5877

Notes

Links

/kind user-story

@dharmit
Copy link
Member

dharmit commented Jun 28, 2022

  • It should watch for all interesting resources (Deployment, ServiceBindings, ...) permanently, i.e. as long as odo dev is running

@feloy I know we discussed this in the grooming call, but I can't recall what it would mean to "watch" for all resources. Can that be elaborated here?

@feloy
Copy link
Contributor

feloy commented Jun 28, 2022

Watch means using the Watch operation of the Kubernetes API, to run a non terminating HTTP request and get events every time a resource we are watching is created / modified / deleted.

We are using this Watch operation in odo, for example here (https://github.com/redhat-developer/odo/blob/main/pkg/kclient/projects.go#L72) to watch for projects resources, and wait for a DELETE event on the specific resource we are waiting to be deleted.

@rm3l rm3l added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Jun 29, 2022
@valaparthvi valaparthvi moved this to In Progress in odo v3-beta2 Jul 5, 2022
@valaparthvi valaparthvi moved this from In Progress to For review in odo v3-beta2 Jul 6, 2022
@feloy feloy moved this from For review to In Progress in odo v3-beta2 Jul 8, 2022
@feloy feloy moved this from In Progress to For review in odo v3-beta2 Jul 12, 2022
@rm3l rm3l linked a pull request Aug 8, 2022 that will close this issue
8 tasks
@rm3l
Copy link
Member Author

rm3l commented Aug 8, 2022

/close

Last point (It should wait until the container is listening on the intended port before stating the application is ready) will be addressed as part of #5877

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2022

@rm3l: Closing this issue.

In response to this:

/close

Last point (It should wait until the container is listening on the intended port before stating the application is ready) will be addressed as part of #5877

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this as completed Aug 8, 2022
Repository owner moved this from For review to Done in odo v3-beta2 Aug 8, 2022
@rm3l rm3l added the v3 label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants