Making cross compile independent of gox vender package #2047

amitkrout · 2019-08-26T11:40:43Z

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

#1998 (comment)

How to test changes?

make cross

mohammedzee1000 · 2019-08-26T12:11:19Z

You can make this cleaner by doing it in a shell script and calling it here I think
or having separate targets for each os like how it's done for oc and call all of them for cross

amitkrout · 2019-08-26T15:35:12Z

.PHONY: cross
cross:
    @for platform in linux darwin windows ; do \
        if [ $$platform == "windows" ]; then \
        IS_EXE := .exe; \
        fi \
        go build -o dist/bin/$$platform-amd64/odo$(IS_EXE) $(BUILD_FLAGS) ./cmd/odo/ \
    done

I prefer this over the change i made. But unfortunately the syntax fix took longer time without success. If anybody fix the error please comment cc_ @mohammedzee1000 @kadel

mohammedzee1000 · 2019-08-26T15:35:34Z

Makefile

@@ -79,10 +79,27 @@ goget-tools:
 test-coverage:
 	./scripts/generate-coverage.sh

+# compile for linux platform


Maybe set GOOS before doing it :

env GOOS=linux go build -blah

@mohammedzee1000 Something like ?

.PHONY: darwin-amd64 darwin-amd64: GOARCH=amd64 GOOS=darwin go build $(BUILD_FLAGS) -o dist/bin/darwin-amd64/odo ./cmd/odo/

mohammedzee1000 · 2019-08-27T05:17:22Z

Makefile

-	gox -osarch="darwin/amd64 linux/amd64 windows/amd64" -output="dist/bin/{{.OS}}-{{.Arch}}/odo" $(BUILD_FLAGS) ./cmd/odo/
+	@for platform in linux darwin windows ; do \
+		if [ $$platform == "windows" ]; then \
+			echo "Cross compiling $$platform-amd64 and placing binary at dist/bin/$$platform-amd64/"; \


You can put the echo before if as its common

Could not get it. Can you please explain it

Got it, thanks
Will update it

amitkrout · 2019-08-27T05:50:03Z

.PHONY: cross
cross:
    @for platform in linux darwin windows ; do \
        if [ $$platform == "windows" ]; then \
        IS_EXE := .exe; \
        fi \
        go build -o dist/bin/$$platform-amd64/odo$(IS_EXE) $(BUILD_FLAGS) ./cmd/odo/ \
    done
I prefer this over the change i made. But unfortunately the syntax fix took longer time without success. If anybody fix the error please comment cc_ @mohammedzee1000 @kadel

Finally able to fix the syntax error.

kadel · 2019-08-27T09:21:40Z

Please remove gox from makefile and from other places if it is mentioned somewhere

mohammedzee1000

Looking good
/approve

openshift-ci-robot · 2019-08-27T09:32:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohammedzee1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mohammedzee1000]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mohammedzee1000 · 2019-08-27T09:32:29Z

It works, although as stated by @kadel remove remaining references

amitkrout · 2019-08-27T13:35:48Z

Please remove gox from makefile and from other places if it is mentioned somewhere

Done

$ git grep -n "gox"
Binary file tests/examples/binary/java/openjdk/sb.jar matches
Binary file vendor/github.com/openshift/origin/docs/proposals/wireframes/Project-logs.png matches
vendor/golang.org/x/text/language/display/tables.go:16418:      "ongoxinès simplificatxinès tradicional"

amitkrout · 2019-08-27T15:12:40Z

[odo]  ✗  Failed To Update Config To Component Deployed
[odo]  ✗  Applying configuration [55s]

/test integration

amitkrout · 2019-08-27T15:13:32Z

/refresh

mohammedzee1000 · 2019-08-28T09:07:06Z

• Failure [156.587 seconds]
odoJavaE2e
/go/src/github.com/openshift/odo/tests/integration/java_test.go:13
  odo component creation
  /go/src/github.com/openshift/odo/tests/integration/java_test.go:41
    Should be able to deploy a spring boot uberjar file using openjdk [It]
    /go/src/github.com/openshift/odo/tests/integration/java_test.go:94
     Failed after 90 retries. Content in http://uberjaropenjdk-app-phppkfrfmn.apps.ci-op-dr740dig-f09f4.origin-ci-int-aws.dev.rhcloud.com doesn't include 'HTTP Booster'.
     /go/src/github.com/openshift/odo/tests/helper/helper_http.go:41
------------------------------
 Summarizing 1 Failure:
 [Fail] odoJavaE2e odo component creation [It] Should be able to deploy a spring boot uberjar file using openjdk 
/go/src/github.com/openshift/odo/tests/helper/helper_http.go:41
 Ran 4 of 97 Specs in 315.104 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 93 Skipped

Something up with springboot

mohammedzee1000 · 2019-08-28T09:07:33Z

/retest

amitkrout · 2019-08-28T11:43:23Z

/test integration

kadel · 2019-08-28T12:55:40Z

/lgtm

kadel · 2019-08-28T12:56:47Z

/retest

- Lists all URLs even if they are undeployed or not (redhat-developer#2034) - Added json output for `odo project delete -o json` (redhat-developer#2037) - Fixed service integration test that was previously failing (redhat-developer#2022) - `odo push` will now only push changed files (redhat-developer#2030) - We now use relative paths within the file indexer (redhat-developer#2003) - You can now create list and edit services using --app and --project (redhat-developer#2001) - Deleted files will now propagate to the OpenShift container (redhat-developer#1999) - Added `odo service create --context` functionality (redhat-developer#1997) - Making cross-compile independant of gox vendor package (redhat-developer#2047) - `odo-supervisord-image` has been renamed to `odo-init-image` (redhat-developer#2027) - Releases now use .tar.gz (redhat-developer#2009) - If there is an error creating a service, it will fail quicker (redhat-developer#2008) - We now have a Google Group! (redhat-developer#2007) - Added documentation on how to manage environment variables(redhat-developer#2026) - Badges added to the README (redhat-developer#2060) - Updated documentation on uninstallation (redhat-developer#2053) - Added documentation for default parameters (redhat-developer#2038) - Minor update to help output (redhat-developer#2006) - Updated documentation regarding bootstrapper image (redhat-developer#1991)

- Lists all URLs even if they are undeployed or not (#2034) - Added json output for `odo project delete -o json` (#2037) - Fixed service integration test that was previously failing (#2022) - `odo push` will now only push changed files (#2030) - We now use relative paths within the file indexer (#2003) - You can now create list and edit services using --app and --project (#2001) - Deleted files will now propagate to the OpenShift container (#1999) - Added `odo service create --context` functionality (#1997) - Making cross-compile independant of gox vendor package (#2047) - `odo-supervisord-image` has been renamed to `odo-init-image` (#2027) - Releases now use .tar.gz (#2009) - If there is an error creating a service, it will fail quicker (#2008) - We now have a Google Group! (#2007) - Added documentation on how to manage environment variables(#2026) - Badges added to the README (#2060) - Updated documentation on uninstallation (#2053) - Added documentation for default parameters (#2038) - Minor update to help output (#2006) - Updated documentation regarding bootstrapper image (#1991)

openshift-ci-robot added the size/XS label Aug 26, 2019

openshift-ci-robot requested review from dharmit and mohammedzee1000 August 26, 2019 11:41

amitkrout changed the title ~~Making cross compile independent of gox vender package~~ [WIP] Making cross compile independent of gox vender package Aug 26, 2019

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 26, 2019

amitkrout mentioned this pull request Aug 26, 2019

Dockerfile is used by CI to publish odo artifacts #1998

Merged

openshift-ci-robot added size/S and removed size/XS labels Aug 26, 2019

amitkrout changed the title ~~[WIP] Making cross compile independent of gox vender package~~ Making cross compile independent of gox vender package Aug 26, 2019

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 26, 2019

mohammedzee1000 reviewed Aug 26, 2019

View reviewed changes

mohammedzee1000 reviewed Aug 27, 2019

View reviewed changes

openshift-ci-robot added size/XS and removed size/S labels Aug 27, 2019

mohammedzee1000 approved these changes Aug 27, 2019

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 27, 2019

amitkrout added 8 commits August 27, 2019 19:02

Making cross compile indepedent of gox vender package

a353dc4

Fixing Makefile failure

c505ef4

Updated Makefile

fd66441

Updated Makefile

b3ebfcb

Updated Makefile as per review comment

8618899

Updated Makefile

6d1f37c

Update Makefile

90d6fc0

Remove gox reference

0792b90

amitkrout force-pushed the crossCompile branch from 3c0786a to 0792b90 Compare August 27, 2019 13:35

openshift-ci-robot added size/S and removed size/XS labels Aug 27, 2019

openshift-ci-robot assigned kadel Aug 28, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 28, 2019

openshift-merge-robot merged commit 2fbb154 into redhat-developer:master Aug 28, 2019

cdrage mentioned this pull request Sep 3, 2019

Release 1.0.0-beta5 #2075

Merged

rm3l added the estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person label Jun 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Making cross compile independent of gox vender package #2047

Making cross compile independent of gox vender package #2047

amitkrout commented Aug 26, 2019

mohammedzee1000 commented Aug 26, 2019 •

edited

Loading

amitkrout commented Aug 26, 2019

mohammedzee1000 Aug 26, 2019 •

edited

Loading

amitkrout Aug 26, 2019 •

edited

Loading

mohammedzee1000 Aug 26, 2019

mohammedzee1000 Aug 27, 2019

amitkrout Aug 27, 2019

amitkrout Aug 27, 2019

amitkrout Aug 27, 2019

amitkrout commented Aug 27, 2019

kadel commented Aug 27, 2019

mohammedzee1000 left a comment

openshift-ci-robot commented Aug 27, 2019

mohammedzee1000 commented Aug 27, 2019

amitkrout commented Aug 27, 2019 •

edited

Loading

amitkrout commented Aug 27, 2019

amitkrout commented Aug 27, 2019

mohammedzee1000 commented Aug 28, 2019

mohammedzee1000 commented Aug 28, 2019

amitkrout commented Aug 28, 2019

kadel commented Aug 28, 2019 •

edited

Loading

kadel commented Aug 28, 2019

Making cross compile independent of gox vender package #2047

Making cross compile independent of gox vender package #2047

Conversation

amitkrout commented Aug 26, 2019

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

How to test changes?

mohammedzee1000 commented Aug 26, 2019 • edited Loading

amitkrout commented Aug 26, 2019

mohammedzee1000 Aug 26, 2019 • edited Loading

Choose a reason for hiding this comment

amitkrout Aug 26, 2019 • edited Loading

Choose a reason for hiding this comment

mohammedzee1000 Aug 26, 2019

Choose a reason for hiding this comment

mohammedzee1000 Aug 27, 2019

Choose a reason for hiding this comment

amitkrout Aug 27, 2019

Choose a reason for hiding this comment

amitkrout Aug 27, 2019

Choose a reason for hiding this comment

amitkrout Aug 27, 2019

Choose a reason for hiding this comment

amitkrout commented Aug 27, 2019

kadel commented Aug 27, 2019

mohammedzee1000 left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Aug 27, 2019

mohammedzee1000 commented Aug 27, 2019

amitkrout commented Aug 27, 2019 • edited Loading

amitkrout commented Aug 27, 2019

amitkrout commented Aug 27, 2019

mohammedzee1000 commented Aug 28, 2019

mohammedzee1000 commented Aug 28, 2019

amitkrout commented Aug 28, 2019

kadel commented Aug 28, 2019 • edited Loading

kadel commented Aug 28, 2019

mohammedzee1000 commented Aug 26, 2019 •

edited

Loading

mohammedzee1000 Aug 26, 2019 •

edited

Loading

amitkrout Aug 26, 2019 •

edited

Loading

amitkrout commented Aug 27, 2019 •

edited

Loading

kadel commented Aug 28, 2019 •

edited

Loading