Adds odo project delete -o json
#2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests have been added and this is ready for review 🎉 |
odo project create -o jsonodo project delete -o json
24a6c70 to
4a47e5c
Compare
dharmit
suggested changes
Aug 23, 2019
| @@ -61,22 +61,32 @@ func (pdo *ProjectDeleteOptions) Validate() (err error) { | |||
|
|
|||
| // Run runs the project delete command | |||
| func (pdo *ProjectDeleteOptions) Run() (err error) { | |||
| // this to set the project in the file and runtime | |||
|
|
|||
| // This to set the project in the file and runtime | |||
Shouldn't we provide a value for |
|
/retest |
4a47e5c to
ccf316e
Compare
|
/retest |
amitkrout
reviewed
Aug 28, 2019
|
/test integration |
|
/retest all |
ccf316e to
42a2c96
Compare
Adds capability for `odo project delete -o json` output.
To test
```sh
github.com/openshift/odo json-delete-project ✗ 1h50m ⚑ ⍉
▶ ./odo project create foobar -o json | jq
{
"kind": "Project",
"apiVersion": "odo.openshift.io/v1alpha1",
"metadata": {
"name": "foobar",
"namespace": "foobar",
"creationTimestamp": null
},
"message": "Project 'foobar' is ready for use"
}
github.com/openshift/odo json-delete-project ✗ 1h50m ⚑
▶ ./odo project delete foobar -o json | jq
{
"kind": "Project",
"apiVersion": "odo.openshift.io/v1alpha1",
"metadata": {
"name": "foobar",
"namespace": "foobar",
"creationTimestamp": null
},
"message": "Deleted project foobar"
}
```
42a2c96 to
11a8fff
Compare
|
I've been re-running this test about 10 times now, still running into "Terraform" issues. Any ideas @mohammedzee1000 ? |
|
/retest |
|
Need one more review! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cdrage
added a commit
to cdrage/odo
that referenced
this pull request
Sep 3, 2019
- Lists all URLs even if they are undeployed or not (redhat-developer#2034) - Added json output for `odo project delete -o json` (redhat-developer#2037) - Fixed service integration test that was previously failing (redhat-developer#2022) - `odo push` will now only push changed files (redhat-developer#2030) - We now use relative paths within the file indexer (redhat-developer#2003) - You can now create list and edit services using --app and --project (redhat-developer#2001) - Deleted files will now propagate to the OpenShift container (redhat-developer#1999) - Added `odo service create --context` functionality (redhat-developer#1997) - Making cross-compile independant of gox vendor package (redhat-developer#2047) - `odo-supervisord-image` has been renamed to `odo-init-image` (redhat-developer#2027) - Releases now use .tar.gz (redhat-developer#2009) - If there is an error creating a service, it will fail quicker (redhat-developer#2008) - We now have a Google Group! (redhat-developer#2007) - Added documentation on how to manage environment variables(redhat-developer#2026) - Badges added to the README (redhat-developer#2060) - Updated documentation on uninstallation (redhat-developer#2053) - Added documentation for default parameters (redhat-developer#2038) - Minor update to help output (redhat-developer#2006) - Updated documentation regarding bootstrapper image (redhat-developer#1991)
Merged
openshift-merge-robot
pushed a commit
that referenced
this pull request
Sep 3, 2019
- Lists all URLs even if they are undeployed or not (#2034) - Added json output for `odo project delete -o json` (#2037) - Fixed service integration test that was previously failing (#2022) - `odo push` will now only push changed files (#2030) - We now use relative paths within the file indexer (#2003) - You can now create list and edit services using --app and --project (#2001) - Deleted files will now propagate to the OpenShift container (#1999) - Added `odo service create --context` functionality (#1997) - Making cross-compile independant of gox vendor package (#2047) - `odo-supervisord-image` has been renamed to `odo-init-image` (#2027) - Releases now use .tar.gz (#2009) - If there is an error creating a service, it will fail quicker (#2008) - We now have a Google Group! (#2007) - Added documentation on how to manage environment variables(#2026) - Badges added to the README (#2060) - Updated documentation on uninstallation (#2053) - Added documentation for default parameters (#2038) - Minor update to help output (#2006) - Updated documentation regarding bootstrapper image (#1991)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds capability for
odo project create -o jsonoutput.To test: