Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ubi8/nodejs-14 as supported #78

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Adding ubi8/nodejs-14 as supported #78

merged 1 commit into from
Dec 17, 2020

Conversation

prietyc123
Copy link
Contributor

Adding ubi8/nodejs-14 image as supported to make sure nodejs latest on ocp 4.7 executes successfully. This will fix a part of redhat-developer/odo#4303 . There is one more pr redhat-developer/odo#4304 which is dependent on this pr

ping @kadel

@prietyc123 prietyc123 mentioned this pull request Dec 11, 2020
Merged
4 tasks
@kadel
Copy link
Member

kadel commented Dec 11, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel, prietyc123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020
dharmit
dharmit approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@dharmit
Copy link
Member

dharmit commented Dec 16, 2020

/hold

@prietyc123 why are the tests failing on this one? When I open the prow page, all it says is:

failed to get PR history: failed to list directories for PR openshift/odo-init-image #78: couldn't find presubmits for "openshift/odo-init-image" in config

🤔

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2020
@prietyc123
Copy link
Contributor Author

@prietyc123 why are the tests failing on this one? When I open the prow page, all it says is:

failed to get PR history: failed to list directories for PR openshift/odo-init-image #78: couldn't find presubmits for "openshift/odo-init-image" in config

@dharmit Could you please point me to the full log?

@dharmit
Copy link
Member

dharmit commented Dec 17, 2020

@dharmit Could you please point me to the full log?

That's exactly what I have pointed you to! 🤷‍♂️

If I click on any of the "full test history" links posted by the bot, that one-liner is all I see.

@prietyc123
Copy link
Contributor Author

If I click on any of the "full test history" links posted by the bot, that one-liner is all I see.

Ahh yes it might be happening due to travis failed checks. This is no where related to the current change in the pr. There is a lot of mess comes up after odo init 1.1.5 . This failure is common across all the pr. FYI check #75

@dharmit
Copy link
Member

dharmit commented Dec 17, 2020

This failure is common across all the pr. FYI check #75

That PR is just about bumping the version. I remember you mentioned #70 as being the cause of some mess but I am unsure how that would mess things either. But that might be lack of understanding on my part.

@prietyc123
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@dharmit dharmit merged commit a2159d9 into redhat-developer:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit approved these changes

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prietyc123 @kadel @openshift-ci-robot @openshift-bot @dharmit