Added ODO_S2I_CONVERTED_DEVFILE env variable #70
Conversation
assemble-and-restart
Outdated
| # This is a dumb way to restart as supervisord does not have a restart function | ||
| ${ODO_UTILS_DIR}/bin/supervisord ctl stop run; ${ODO_UTILS_DIR}/bin/supervisord ctl start run | ||
| # following script need not to run for s2i components converted to devfile | ||
| # for converted components devfile push code assures the following steps |
There was a problem hiding this comment.
A little confused by the comment. First line says that the below script should not run for components converted to devfile. Second line says that devfile push code assures below steps for converted components. Sounds opposite to me. Do you think we can reword it?
There was a problem hiding this comment.
for components converted to devfile, we don't need to run following steps. As this steps already run by devifile push code
is this sound ok to you?
There was a problem hiding this comment.
Yep it does. Earlier one made me think like - "these steps don't get executed, but these steps get executed". Maybe my bad. But above sounds perfect. 👍
Some changes needs to be done in scripts for components converted from s2i to devfile
17eae18 to
435900e
Compare
|
/approve |
|
ping approvers - @kadel |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit, kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To enable easy migration from s2i components to devfile,
ODO_S2I_CONVERTED_DEVFILEenvironment variable is inserted to component whileodo utils convert-to-devfile. There are some changes in script if this flag is enabled.