Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: regenerating SDK and fixing CICD process #76

Merged
merged 10 commits into from
Aug 10, 2021
Merged

chore: regenerating SDK and fixing CICD process #76

merged 10 commits into from
Aug 10, 2021

Conversation

wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Aug 10, 2021

This can be verified locally by executing:

./scripts/build.sh 

Generate also should have no changes (no need to test but)

./scripts/generate.sh 

@wtrocki wtrocki changed the title Fix build chore: regenerating SDK and fixing CICD process Aug 10, 2021
@wtrocki
Copy link
Collaborator Author

wtrocki commented Aug 10, 2021

There are a couple of problems here still.

  • Imports are missing for filters (I have added them manually for the moment):

Screenshot 2021-08-10 at 12 02 13

There is openapi bug that solves this problem:
OpenAPITools/openapi-generator#8815

However entire ACL API is not usable and clearly broken:

ACLfilters should be generated as strings but they just empty classes.
We need to report that to the backend team and entire filtering should be refactored in schema as it is not working

@wtrocki wtrocki requested review from secondsun and craicoverflow and removed request for secondsun August 10, 2021 11:05
@craicoverflow
Copy link

LGTM

@wtrocki wtrocki merged commit de95163 into main Aug 10, 2021
@wtrocki wtrocki deleted the fix-build branch August 10, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants