Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka admin ACL API breaks compilation #78

Closed
wtrocki opened this issue Aug 10, 2021 · 2 comments
Closed

Kafka admin ACL API breaks compilation #78

wtrocki opened this issue Aug 10, 2021 · 2 comments
Assignees

Comments

@wtrocki
Copy link
Collaborator

wtrocki commented Aug 10, 2021

ACL api filters are not properly designed in Openapi doc generating empty files and breaking compilation.

  • Imports are missing for filters (I have added them manually for the moment):

Screenshot 2021-08-10 at 12 02 13

There is openapi bug that solves code compilation problem:
OpenAPITools/openapi-generator#8815

However entire ACL API is not usable:
ACLfilters should be generated as strings but they are just empty classes.
We need to report that to the backend team and entire filtering should be refactored in schema as it is not working

Originally posted by @wtrocki in #76 (comment)

@wtrocki
Copy link
Collaborator Author

wtrocki commented Aug 10, 2021

@wtrocki
Copy link
Collaborator Author

wtrocki commented Aug 10, 2021

Follow up updates will not break it as we have added those files to openapiignore however we should look to clarify and fix this with the kafka team.

@wtrocki wtrocki self-assigned this Aug 10, 2021
@wtrocki wtrocki closed this as completed Aug 11, 2021
andreaTP pushed a commit to andreaTP/app-services-sdk-java that referenced this issue Jan 19, 2023
chore: build on tag instead of push to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant