Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API validation works only for golang SDK #70

Closed
wtrocki opened this issue Aug 5, 2021 · 2 comments
Closed

API validation works only for golang SDK #70

wtrocki opened this issue Aug 5, 2021 · 2 comments

Comments

@wtrocki
Copy link
Collaborator

wtrocki commented Aug 5, 2021

Golang SDK has validation for api standards that needs to be moved.
@wtrocki
Copy link
Collaborator Author

wtrocki commented Aug 5, 2021

See redhat-developer/app-services-sdk-js#139

@craicoverflow
Copy link

2021/08/05 15:36:02 encountered disallowed external reference: "kas-fleet-manager.yaml#/components/schemas/Error"

This comes from a separate library which does not support external references. The error happens here: https://github.com/redhat-developer/app-services-sdk-go/blob/d3ef7c96e96df7031f48dd706bbe3e9b92e3b4a8/internal/apigen/generator/golang/generate.go#L62

See oapi-codegen/oapi-codegen#42

So there is nothing to worry about here, there is no missing validation.

andreaTP pushed a commit to andreaTP/app-services-sdk-java that referenced this issue Jan 19, 2023
@secondsun
Merge pull request redhat-developer#70 from bf2fc6cc711aee1a0c2a/chan…
07b787f 
…ge-api

BREAKING: change API for managed services requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wtrocki @craicoverflow