Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API validation works only for golang SDK #139

Closed
wtrocki opened this issue Aug 5, 2021 · 3 comments
Closed

API validation works only for golang SDK #139

wtrocki opened this issue Aug 5, 2021 · 3 comments

Comments

@wtrocki
Copy link
Collaborator

wtrocki commented Aug 5, 2021

Validator doesn't seem to be working in js and java.
@craicoverflow
Copy link

Shouldn't this issue instead be added to the Java,JavaScript repos?

@wtrocki wtrocki transferred this issue from redhat-developer/app-services-sdk-go Aug 5, 2021
@wtrocki wtrocki mentioned this issue Aug 5, 2021
Closed
@wtrocki
Copy link
Collaborator Author

wtrocki commented Aug 5, 2021

@craicoverflow Problem is that I do not know how this works and gets integrated so could not provide more detailed info

@craicoverflow
Copy link

2021/08/05 15:36:02 encountered disallowed external reference: "kas-fleet-manager.yaml#/components/schemas/Error"

This comes from a separate library which does not support external references. The error happens here: https://github.com/redhat-developer/app-services-sdk-go/blob/d3ef7c96e96df7031f48dd706bbe3e9b92e3b4a8/internal/apigen/generator/golang/generate.go#L62

See oapi-codegen/oapi-codegen#42

So there is nothing to worry about here, there is no missing validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wtrocki @craicoverflow